Fix: Windows MTL build system, updated msys2_build.yml#1129
Open
Fix: Windows MTL build system, updated msys2_build.yml#1129
Conversation
Mionsz
requested review from
DawidWesierski4,
Falron98,
Sakoram and
skolelis
as code owners
FIXED: Windows MTL build system, update msys2_build.yml - added mandatory fixes fot windows build to work with DPDK - run all build cases using mingw64 environemnt - minor fixes to the code due to build failing UPADTE: updated to allow msys2_build.yml to use github hosted runner and set runner OS version to all 3 available windowses. Signed-off-by: Milosz Linkiewicz <milosz.linkiewicz@intel.com>
Mionsz
force-pushed
the
private/mlinkiew/windows-2019-msys2
branch
from
8d3f9ae to
60a717e
Compare
DawidWesierski4
changed the title
DawidWesierski4
approved these changes
Apr 15, 2025
Collaborator
DawidWesierski4
left a comment
DawidWesierski4
left a comment
There was a problem hiding this comment.
I would love to udnerstand why we disabled JIT compiling i will IMO LGTM
but i would send this to sombady better wersed with CICD as I'm not very capable
Collaborator
Author
|
This was deprioritized and will not be merged to main @DawidWesierski4. |
…rily unavailable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXED: Windows MTL build system, update msys2_build.yml
UPADTE: updated to allow msys2_build.yml to use GitHub hosted runner and set runner OS version to all 3 available windowses.