Fix: drain chain mbufs before queue release on TX restart#1439
Closed
Fix: drain chain mbufs before queue release on TX restart#1439
Conversation
After TX video session restart, chain mbufs holding extbuf references to frame_info->sh_info could remain in the NIC TX descriptor ring. When frames were freed during tv_uinit_sw, subsequent descriptor completion triggered rte_pktmbuf_free_extbuf on freed sh_info memory, causing payload corruption visible only with chain mbufs (not tx_no_chain). Restructure tv_uinit_hw into 4 phases: drain software rings, flush all queues with pad packets, verify chain mempool is drained via rte_eth_tx_done_cleanup while queues are still alive, then release queues. Apply the same flush+drain pattern in st20_tx_queue_fatal_error before releasing the old queue and resetting sh_info refcnts. Signed-off-by: Kasiewicz, Marek <marek.kasiewicz@intel.com>
Collaborator
Author
|
did not help on the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After TX video session restart, chain mbufs holding extbuf references to frame_info->sh_info could remain in the NIC TX descriptor ring. When frames were freed during tv_uinit_sw, subsequent descriptor completion triggered rte_pktmbuf_free_extbuf on freed sh_info memory, causing payload corruption visible only with chain mbufs (not tx_no_chain).
Restructure tv_uinit_hw into 4 phases: drain software rings, flush all queues with pad packets, verify chain mempool is drained via rte_eth_tx_done_cleanup while queues are still alive, then release queues. Apply the same flush+drain pattern in
st20_tx_queue_fatal_error before releasing the old queue and resetting sh_info refcnts.