fix(mcp): strict dry-run command validation (#55)#24
Merged
chenliuyun merged 2 commits intomainfrom Apr 21, 2026
Merged
Conversation
added 2 commits
April 21, 2026 12:03
…eCommand (#55) Replace validateCommand call in send_command dry-run with direct catalog lookup. When findCatalogEntry returns a definitive match with builtin commands, reject unknown command names. Also reject commands on read-only sensors. Pass through gracefully for uncataloged device types.
README and agent-guide now document that dry-run validates command names against the catalog and rejects commands on read-only sensors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateCommandinsend_commanddry-run with directfindCatalogEntrylookupFixes #55 (v2.6.2 fix was insufficient —
validateCommandsilently returnedok:truefor ambiguous/missing catalog matches).Test plan
unknown-commandturnon) → accepted (case-normalized)read-only-device