fix(spec2006): apply benchmark post-setup in package rootfs#17
Merged
Conversation
Some SPEC2006 benchmarks rely on post-setup work that runspec performs in the benchmark run directory after staging inputs. Our package helper copied the inputs into /spec but skipped those benchmark-specific post-setup steps, so the exported rootfs could miss generated runtime files. Apply the relevant post-setup logic in the package tree before packing the rootfs. Generate the sphinx3 ctlfile and target-endian raw inputs under /spec, and copy the wrf endian-specific data files while choosing RRTM_DATA according to wrf_data_header_size in the selected SPEC config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some SPEC2006 benchmarks rely on post-setup work that runspec performs in the benchmark run directory after staging inputs. Our package helper copied the inputs into /spec but skipped those benchmark-specific post-setup steps, so the exported rootfs could miss generated runtime files.
Apply the relevant post-setup logic in the package tree before packing the rootfs. Generate the sphinx3 ctlfile and target-endian raw inputs under /spec, and copy the wrf endian-specific data files while choosing RRTM_DATA according to wrf_data_header_size in the selected SPEC config.