This repository was archived by the owner on Jan 24, 2022. It is now read-only.
Check package json version instead of zos version for dependencies#309
Open
spalladino wants to merge 1 commit intomasterfrom
Open
Check package json version instead of zos version for dependencies#309spalladino wants to merge 1 commit intomasterfrom
spalladino wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
We already discussed this offline, but I'm dropping my comment here anyway. I don't like the idea of coupling the package.json version to the zos.json. I'd prefer working on some improvements that prevent the user to get those files unsynched, additionally, we should reconsider the versions validations we are doing to see if there is a way to handle this scenario improving the user experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes all dependency version validations to check against the package.json version instead of the zos.json version. This allows publishing an update of the npm package without modifying the zos.json versions. The downside is that we are coupling the zos.json declared dependency with npm versioning (the dependencies node of the zos.json file will now list dependencies with their npm version, and not their zos version), but we can review this in the future when we allow other package managers to be used. We can discuss whether this is the best approach though, as it allows to completely unsync the npm version and the zos version for a dependency, and whether to merge it now in case it introduces potential new issues.
We do use the zos.json version to check the zos.network.json files. If a dependency updates its zos.json version, but fails to update a zos.network.json, the consumer will reject using the dependency on that network.
Fixes #308