Merged
Conversation
RegionGroupsMap and CoreAccountsMap relied on Decode(string) error to deserialize JSON strings from environment variables. Viper v1.21 switched from mitchellh/mapstructure to go-viper/mapstructure/v2, which recognizes encoding.TextUnmarshaler instead of the Decode interface. Add UnmarshalText([]byte) error alongside the existing Decode methods so both mapstructure versions work correctly.
Test Results58 tests 58 ✅ 0s ⏱️ Results for commit d2632bd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issues for these changes
Types of changes
Checklist
README.md,CHANGELOG.md, etc. - if appropriate)Dependencies and Blockers
Relevant Links
Further comments