Complete issues #144 and #147 with a green deep matrix#150
Complete issues #144 and #147 with a green deep matrix#150Anthony Johnson II (AJ-EthereaLogic-ai) wants to merge 2 commits into
Conversation
Task: tsk_20260720_0003 Criteria: - deterministically exercise and reject the body-only agent-key mutation on Linux - keep /opt/npm-cache descendants writable for arbitrary runtime UID:GID - preserve PR #148 skip semantics while satisfying rendered ty checks - pass Tier 1, focused deep legs, both TypeScript renderers, and the full seven-variant/two-renderer RUN_VALIDATE=1 matrix - keep changes limited to the six approved test, local-CI, changelog, and dashboard paths
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Task: tsk_20260720_0003 Record the focused, Tier 1, arbitrary-UID, targeted deep, and complete matrix evidence in the tracked dashboard so strict diff-only verification can evaluate the execution criteria. Preserve the linked-worktree pre-leg failure separately from the successful exact-commit matrix.
Root cause
agents/*.mdentry, which could beREADME.md; mutating that file did not exercise an actual agent definition, so the Linux regression was nondeterministic./opt/npm-cachebefore dependency installation, but root-created descendants could remain unwritable when local CI later ran as an arbitrary host UID:GID.pytest.skipcall forms introduced by PR refactor: issue #111 remaining cleanups — loader fan-out, read-lines helper, dead code, __main__ guard, copier portability #148.Change
/opt/npm-cacheafter installs, without broadening runtime privileges or changing the host-UID execution model._TEMPLATE_SOURCEpytest.mark.skipifpattern and unchanged reason text.Impact
The governance regression now deterministically exercises a real agent on Linux. Arbitrary runtime UIDs can write every required npm-cache descendant. Rendered ty accepts the preserved template-source skip behavior. Validation runners, package manifests, matrix selection, hooks, workflows, Jinja expressions, and
check-governance.share unchanged.Checks
1 passed in 0.38s; Linux/arm641 passed in 0.10s.10 passed in 2.39s.uid=12345 gid=23456 cache-write=PASS npm-cache-verify=PASS.dd82f8921df98b3e2c4aa146ddf77281047cfee7:{"event":"gate","run_id":"20260720T044837Z","git_commit":"dd82f8921df98b3e2c4aa146ddf77281047cfee7","branch":"adws/job_20260720_0003/issues-144-147-deep-green","dirty":false,"overall":"pass","steps":[{"step":"pytest","status":"pass","duration_s":7},{"step":"render-smoke","status":"pass","duration_s":1}]}{"event":"orb_matrix","run_id":"20260720T043115Z","git_commit":"916b0468e0608ea096bd22dab9d5d514421813a3","run_validate":"1","overall":"pass","legs":[{"step":"pytest","status":"pass"},{"tool":"cookiecutter","variant":"python-mit-ty","language":"python","status":"pass","duration_s":7},{"tool":"copier","variant":"python-mit-ty","language":"python","status":"pass","duration_s":7},{"tool":"cookiecutter","variant":"python-mit-mypy","language":"python","status":"pass","duration_s":9},{"tool":"copier","variant":"python-mit-mypy","language":"python","status":"pass","duration_s":8},{"tool":"cookiecutter","variant":"python-apache-sbom-ty","language":"python","status":"pass","duration_s":7},{"tool":"copier","variant":"python-apache-sbom-ty","language":"python","status":"pass","duration_s":8},{"tool":"cookiecutter","variant":"typescript-mit","language":"typescript","status":"pass","duration_s":5},{"tool":"copier","variant":"typescript-mit","language":"typescript","status":"pass","duration_s":4},{"tool":"cookiecutter","variant":"typescript-apache-tools","language":"typescript","status":"pass","duration_s":4},{"tool":"copier","variant":"typescript-apache-tools","language":"typescript","status":"pass","duration_s":4},{"tool":"cookiecutter","variant":"polyglot-mit-all-ty","language":"polyglot","status":"pass","duration_s":10},{"tool":"copier","variant":"polyglot-mit-all-ty","language":"polyglot","status":"pass","duration_s":10},{"tool":"cookiecutter","variant":"polyglot-mit-all-macaron-mypy","language":"polyglot","status":"pass","duration_s":11},{"tool":"copier","variant":"polyglot-mit-all-macaron-mypy","language":"polyglot","status":"pass","duration_s":11},{"step":"render-equivalence","status":"pass"}]}git diff --check: pass; exact six-file scope confirmed.ADWS evidence:
artifacts/job_20260720_0003/Closes #144
Closes #147
Field-verification evidence
The dashboard now carries a dated, tracked record for the execution-only criteria. It includes the corrected
SkillContractTests::test_governance_check_rejects_body_only_agent_keyhost command, retained focused/Tier 1/UID/targeted-deep outcomes, the exact shipped-code 14-leg matrix JSON, and the linked-worktree clone failure explicitly scoped as occurring before any matrix leg.Fresh test attempt 3 materialized the complete documentation-bearing candidate at scratch commit
04cdafdf80287475f004f57d88e4a55f06a9e63cand reported:1 passed in 0.38s; Linux/arm641 passed in 0.08s;10 passed in 2.44s;python-mit-tydeep leg: pass;uid=12345 gid=23456 cache-write=PASS npm-cache-verify=PASS;typescript-mitdeep run plus equivalence: pass;RUN_VALIDATE=1matrix: all 14 renderer/variant legs plus render equivalence passed in 119s (run_id=20260720T050822Z).The final tracked dashboard commit is
ae750b5504ce85bf1c19a3d5f6cafcda98792a6e. Its normal push ran the tracked pre-push gate successfully:{"event":"gate","run_id":"20260720T052631Z","git_commit":"ae750b5504ce85bf1c19a3d5f6cafcda98792a6e","branch":"adws/job_20260720_0003/issues-144-147-deep-green","dirty":false,"overall":"pass","steps":[{"step":"pytest","status":"pass","duration_s":7},{"step":"render-smoke","status":"pass","duration_s":1}]}These are local-CI and ADWS records; no hosted GitHub Actions pass is claimed.