Skip to content

Draft: Hardware Tests in CI #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xarantolus wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Draft: Hardware Tests in CI #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
48a41ab
Add tarpaulin
xarantolus Feb 15, 2025
99311f8
Also cache from main branch
xarantolus Feb 15, 2025
5331480
Verification in CI
xarantolus Feb 15, 2025
72663c8
Merge branch 'main' into features/tarpaulin
thomasw04 Feb 15, 2025
dcaf5bf
fix cargo-tarpaulin.
thomasw04 Feb 15, 2025
79921f7
Add test coverage configuration
xarantolus Feb 15, 2025
f48a7d1
Report code coverage in CI
xarantolus Feb 15, 2025
1a2c47c
Use container for tests
xarantolus Feb 15, 2025
715c225
Fix CI
xarantolus Feb 15, 2025
9683e37
Fix makefile
xarantolus Feb 15, 2025
74fa894
Fix
xarantolus Feb 15, 2025
93c787c
Fix indent
xarantolus Feb 15, 2025
daaa32c
Add coverage report dependencies
xarantolus Feb 15, 2025
9b707f4
Allow commenting
xarantolus Feb 15, 2025
09f105b
Fix permission
xarantolus Feb 15, 2025
d3f47d9
Exclude top-level Cargo.toml
xarantolus Feb 15, 2025
369e541
Permissions
xarantolus Feb 15, 2025
1128ffd
Add group for build dir
xarantolus Feb 15, 2025
601afa5
Rename job
xarantolus Feb 15, 2025
357890c
Add pre-commit hook for formatting
xarantolus Feb 15, 2025
9ec70f2
Kernel formatting
xarantolus Feb 15, 2025
18648b2
Small improvements
xarantolus Feb 15, 2025
0984652
Include python
xarantolus Feb 16, 2025
8deca2c
Test hardware CI
xarantolus Feb 16, 2025
337389e
Test
xarantolus Feb 16, 2025
3e34324
Test
xarantolus Feb 16, 2025
ea4a479
Merge branch 'main' into ci/hardware
xarantolus Feb 18, 2025
be334b4
Merge branch 'main' into ci/hardware
xarantolus Feb 19, 2025
0f30f42
Merge branch 'main' into ci/hardware
xarantolus May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ RUN --mount=type=cache,target=/var/cache/dnf,id=dev-dnf \
libusb1-devel \
openssl-devel \
lcov \
python3 \
python3-pip \
python3-setuptools \
python3-wheel \
awk \
'dnf-command(copr)' && \
dnf copr enable -y rleh/arm-none-eabi-gdb && \
Expand Down
21 changes: 21 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,24 @@

- name: Build
run: make osiris

hardware-test-stm32-nucleo-l4r5zi:
name: Hardware test for the STM32 Nucleo L4R5ZI
# needs: [build-stm32-nucleo-l4r5zi]
runs-on: stm32l4r5zi
steps:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: recursive

- name: Run hardware test
# See https://github.com/OsirisRTOS/hardware-ci for more information
run: |
SERIAL_ID="$(board_info serial stm32l4r5zi)"
echo "Working with chip $SERIAL_ID"
st-flash --serial "$SERIAL_ID" reset
board_info print --serial "$SERIAL_ID" --flash-size
Comment on lines +136 to +153

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 8 months ago

To fix the issue, we will add a permissions block to the hardware-test-stm32-nucleo-l4r5zi job. Since this job appears to only run hardware tests and does not interact with the repository contents or other GitHub features, the minimal required permission is contents: read. This ensures that the job has only the permissions it needs to function correctly.

Suggested changeset 1
.github/workflows/ci.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -138,2 +138,4 @@
     runs-on: stm32l4r5zi
+    permissions:
+      contents: read
     steps:
EOF
@@ -138,2 +138,4 @@
runs-on: stm32l4r5zi
permissions:
contents: read
steps:
Copilot is powered by AI and may make mistakes. Always verify output.
Loading