fix: resolve all SonarQube issues and add coverage tests#78
Merged
Conversation
- Fix BLOCKER in observability/logger.py (filter logic always returned True) - Replace Union[X, None] with X | None across CLI modules - Reduce cognitive complexity in channel.py, protocol/base.py, protocol/reader_fsm.py, protocol/telemetry.py, group/ring.py, and observability/server.py by extracting helper methods - Add sonar-project.properties for scanner configuration - Add unit tests for telemetry helpers, reader FSM event-lock paths, and protocol base I/O error paths, raising new_coverage from 75.5% to 94.2%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
observability/logger.py— correlation filter always returnedTrueregardless of span validityUnion[X, None]withX | Noneacross all CLI modules (SonarQube prefer modern union syntax)channel.py,protocol/base.py,protocol/reader_fsm.py,protocol/telemetry.py,group/ring.py, andobservability/server.pyby extracting focused helper methodssonar-project.propertiesfor reproducible scanner configurationQuality gate result
new_violationsnew_coveragenew_duplicated_lines_densityAll conditions: OK ✅
Test plan
poetry run pytest— 242 passedpoetry run black --check genesis/ tests/ examples/poetry run mypy