feat: add accessibility labels to torch and cancel buttons#55
Merged
Conversation
The torch and cancel buttons were icon-only with no alternative text, so screen readers could not announce them. Add default English content descriptions and expose optional cancelButtonAccessibilityLabel, torchButtonOnAccessibilityLabel and torchButtonOffAccessibilityLabel scan parameters so consumers can customize/localize them. Closes #54
12 tasks
When a label is not provided (null/blank), no content description is set, keeping the previous behavior unchanged. The English default labels are removed; consumers supply the (localized) labels via the scan parameters.
Merged
10 tasks
alexgerardojacinto
marked this pull request as ready for review
June 17, 2026 14:42
alexgerardojacinto
requested review from
ItsChaceD,
OS-ruimoreiramendes,
andredestro,
capacitor-bot,
jcesarmobile,
markemer and
theproducer
and removed request for
a team
June 17, 2026 14:42
Not being used these days, might as well comment to see if CI passes
OS-pedrogustavobilro
added a commit
that referenced
this pull request
Jun 26, 2026
* fix: prevent Expanded Dark Theme inversion on scanner activity Adds an AppCompat DayNight theme to `OSBARCScannerActivity` so Android does not treat it as a legacy light-themed app and invert its colors when Expanded Dark Theme is enabled. References: https://outsystemsrd.atlassian.net/browse/RMET-5280 * chore(release): prepare for version 2.0.2 Might be 2.1.0 instead if we bundle with #55; depends on merge order / time. * ci: comment failing Sonarcloud step Not being used these days, might as well comment to see if CI passes * docs: Remove unnecessary section from PR template * refactor: Change AppCompat to Material3 theme Following PR comment #56 (comment) * chore: revert to AppCompat due to apk size increase #56 (comment)
# Conflicts: # .github/workflows/run-unit-tests.yml # CHANGELOG.md # docs/README.md # pom.xml
OS-pedrogustavobilro
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Torch and Cancel buttons are icon-only with no alternative text, so screen readers can't announce them. This PR adds the ability to set that alternative text.
cancelButtonAccessibilityLabeltorchButtonOnAccessibilityLabel(torch on)torchButtonOffAccessibilityLabel(torch off)Context
An accessibility audit flagged that the Torch and Cancel buttons have no alternative text, so they are announced incorrectly by screen readers. This exposes the labels as inputs so consumers can provide localized alternative text.
Closes #54
Type of changes
Platforms affected
Tests
Screenshots (if appropriate)
N/A
Checklist