Skip to content

ROU-12911: Migrate scss @import into @use/@forward - #1196

Merged
joselrio merged 10 commits into
ROU-12714from
ROU-12911
Aug 5, 2026
Merged

ROU-12911: Migrate scss @import into @use/@forward#1196
joselrio merged 10 commits into
ROU-12714from
ROU-12911

Conversation

@joselrio

@joselrio joselrio commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This pull request completes the migration of all SCSS partials from @import to the modern @use/@forward syntax, updates the SCSS build pipeline to reflect this change, and makes several related improvements and cleanup tasks. It also bumps gulp to v5 and adds sass-migrator as a dev dependency. Minor code formatting and consistency changes are included in TypeScript files.

SCSS Build Pipeline and Structure Modernization:

  • All SCSS partials now use @use/@forward instead of @import, and the code generation logic in GetPartialsList.js and CreateScssFile.js has been updated to emit @use ... as *; statements, ensuring namespace collision avoidance and correct comment placement. [1] [2] [3] [4] [5] [6]
  • The "Functions & Mixins" section has been merged into the setup variables section. The corresponding file and references (Functions&Mixins.js) have been removed and its path is now included in SetupVariables.js as part of a new barrel file. [1] [2] [3] [4]
  • The SCSS build now emits the abstracts barrel @use as the very first statement in the generated entry file to avoid Dart Sass comment duplication issues. [1] [2]

Build Tooling Updates:

  • Upgrades gulp to v5 and adds sass-migrator as a dev dependency to support and enforce the new SCSS module system. [1] [2]
  • Removes 'import' from the list of silenced Dart Sass deprecation warnings, since all first-party SCSS has migrated away from it.

Code Formatting and Minor Cleanups:

  • Improves code formatting for readability and consistency in several TypeScript files, including better line breaks for multi-line statements and minor string fixes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

These changes ensure the codebase is fully up to date with modern Sass best practices, reduce technical debt, and improve maintainability going forward.

@joselrio
joselrio requested a review from a team as a code owner August 4, 2026 17:47
@joselrio joselrio added the chore label Aug 4, 2026

@BenOsodrac BenOsodrac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joselrio great work on this, code-wise don't anything wrong, lets just align on the merge topic!

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@joselrio
joselrio merged commit 26cd2dc into ROU-12714 Aug 5, 2026
9 checks passed
@joselrio
joselrio deleted the ROU-12911 branch August 5, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants