Conversation
BenOsodrac
approved these changes
Aug 5, 2026
BenOsodrac
left a comment
Contributor
There was a problem hiding this comment.
@joselrio great work on this, code-wise don't anything wrong, lets just align on the merge topic!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request completes the migration of all SCSS partials from
@importto the modern@use/@forwardsyntax, updates the SCSS build pipeline to reflect this change, and makes several related improvements and cleanup tasks. It also bumpsgulpto v5 and addssass-migratoras a dev dependency. Minor code formatting and consistency changes are included in TypeScript files.SCSS Build Pipeline and Structure Modernization:
@use/@forwardinstead of@import, and the code generation logic inGetPartialsList.jsandCreateScssFile.jshas been updated to emit@use ... as *;statements, ensuring namespace collision avoidance and correct comment placement. [1] [2] [3] [4] [5] [6]Functions&Mixins.js) have been removed and its path is now included inSetupVariables.jsas part of a new barrel file. [1] [2] [3] [4]@useas the very first statement in the generated entry file to avoid Dart Sass comment duplication issues. [1] [2]Build Tooling Updates:
gulpto v5 and addssass-migratoras a dev dependency to support and enforce the new SCSS module system. [1] [2]'import'from the list of silenced Dart Sass deprecation warnings, since all first-party SCSS has migrated away from it.Code Formatting and Minor Cleanups:
These changes ensure the codebase is fully up to date with modern Sass best practices, reduce technical debt, and improve maintainability going forward.