ROU-12924: implement UI for interaction patterns - #1198
Open
BenOsodrac wants to merge 6 commits into
Open
Conversation
# Conflicts: # src/scss/01-foundations/_icon-library-odc.scss # src/scss/04-patterns/03-interaction/_floating-actions.scss # src/scss/04-patterns/03-interaction/range-slider/_rangeslider.scss
|
BenOsodrac
marked this pull request as ready for review
August 6, 2026 12:14
gnbm
changed the title
OS-giulianasilva
requested changes
Aug 7, 2026
Comment on lines
+18
to
19
| --osui-floating-actions-button-background-hover: #{variables.$token-bg-primary-base-hover}; | ||
| --osui-floating-actions-button-background-press: #{variables.$token-bg-primary-base-press}; |
Contributor
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| --osui-floating-actions-button-background-hover: #{variables.$token-bg-primary-base-hover}; | |
| --osui-floating-actions-button-background-press: #{variables.$token-bg-primary-base-press}; | |
| --osui-floating-actions-button-background-hover: var(--color-primary-hover); | |
| --osui-floating-actions-button-background-press: var(--color-primary-selected); |
Contributor
There was a problem hiding this comment.
I think the floating action's icons are slightly smaller than in Figma.
Contributor
There was a problem hiding this comment.
We should fix the .input-with-icon-content-icon color to token-icon-default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for PhotoSwipe 4.1.0 (used by the OutSystems platform Lightbox Image block) in the Storybook environment, refines the Lightbox overlay chrome restyling, and improves several UI component styles for consistency and accessibility. It also updates dependencies and enhances the InputWithIcon and FloatingActions patterns for better spec compliance and usability.
PhotoSwipe integration and Lightbox restyling:
photoswipeas a dependency, configured Storybook to serve its assets, and included its CSS and JS in the preview so Lightbox stories accurately reflect platform behavior. The OUI theme now correctly overrides PhotoSwipe's default sprite with icon-font glyphs for overlay chrome. [1] [2] [3] [4]InputWithIcon improvements:
.search-actionsslot, reserved proper input padding to prevent overlap, and documented sizing/state variants. Added a comprehensive spec matrix story to visualize all size and state combinations, improving test coverage and documentation. [1] [2] [3]FloatingActions and RangeSlider refinements:
Dependency updates:
outsystems-design-tokensto version 1.4.1 for the latest design token values.Checklist