-
Notifications
You must be signed in to change notification settings - Fork 73
util: gen_ce_info_and_maps supports CN/KO/TC #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
SaintCoinach is basically abandoned and shouldn't be relied on anymore. |
OK, then I’m lost. I have no idea how to get CSV files using |
|
The upstream maintainers' intent is for everyone to either move to using XIVAPI calls, or write their own extractor based on EXDSchema. Lumina gives you a C# library for doing that. It's not the best answer, but they really do not want to support/maintain SaintCoinach (or by extension, Godbert) anymore. With China now on release parity with global, and Korea catching up for 7.5, they should eventually all use the same schema, so maybe it's possible to have users from China and Korea work with XIVAPI to get the game data from those regions added. |
|
If you have experience with Rust, you can take a look at XIVData Oxidizer and see if it can be modified to work with the non-global regions. This tool is meant as mostly a replacement for the |
I hope this becomes a reality someday.
Thanks, I'll check it out! This looks like it could be really useful. Back to the PR: What should we do now?
|
This is probably the most straightforward solution in the short-term.
If you know of another repository that is suitable and maintained, this could also be an option.
This is not a solution for now. We have no idea if and when XIVAPI might integrate non-global data; it would require someone from the non-global (CN/KO/TC) regions to approach and work with them as a starter.
We are already integrating non-global zone data, so I see no reason not to also include non-global CE data.
|
|
The raphael-rs project uses the augenfrosch API, which might be a temporary workaround. async fn fetch_and_parse<T: SheetData>(lang: &str, schema_override: Option<&str>) -> Vec<T> {
const XIV_API: &str = "https://v2.xivapi.com/api";
const BOILMASTER_CN: &str = "https://boilmaster-chs.augenfrosch.dev/api";
const BOILMASTER_KR: &str = "https://boilmaster-ko.augenfrosch.dev/api";
const BOILMASTER_TW: &str = "https://boilmaster-tc.augenfrosch.dev/api"; |
Since there are other projects currently referencing my repository, I have uploaded the updates to a separate branch using the XIVData Oxidizer to avoid any breaking changes. I’ve also updated the definitions on the main branch as well. |
If these API forks are well maintained and updated in a timely manner, they would allow us to use a XIVAPI-style interface for all regions. |
xiashtra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine for now, though I did notice in testing that our error handling for when XIVAPI is unavailable is not very robust and could use improvements.
I dont know why the definitions for the
KOversion are incorrect, so I have hardcoded them for now.