Migrate existing tasks to typed task parameters - #6
Draft
OvesN wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the custom sample with analyzer-guided migrations for VerifyFileHash, ZipDirectory, and GetFileHash. Harden typed path binding and logging based on end-to-end validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
The typed task-parameter PR chain (dotnet#13971-dotnet#13974) added
AbsolutePath,FileInfo,DirectoryInfo,ITaskItem<T>, and migration analyzers. This draft uses the analyzer as a real task author and migrates three existing in-box tasks rather than adding custom examples.Changes Made
VerifyFileHash.FilefromstringtoAbsolutePath.ZipDirectory.SourceDirectoryandDestinationFiletoITaskItem<DirectoryInfo>andITaskItem<FileInfo>.GetFileHash.FilestoITaskItem<AbsolutePath>[].TaskItem<T>types so these migrations do not require runtime code generation under Native AOT.TypedTaskParameterssample from the previous draft.Testing
VerifyFileHash_Tests,ZipDirectory_Tests, andGetFileHash_Testson net11.0 and net472TaskItemOfTTestson net11.0 and net472TaskExecutionHost_Testson net11.0 and net472GetFileHashmetadata on net11.0 and net472Notes
Analyzer/user experience:
Infodiagnostics. Temporarily promoting them surfaced the migration candidates.VerifyFileHash.File→AbsolutePathZipDirectory.SourceDirectory→ITaskItem<DirectoryInfo>ZipDirectory.DestinationFile→ITaskItem<FileInfo>GetFileHash.Files→ITaskItem<AbsolutePath>[]TaskEnvironment.GetAbsolutePath(File)case inVerifyFileHash; the typed-item migrations required manual edits.Intentional draft limitations:
TaskHostFactoryremains unsupported because that transport erases typed parameter types. Normal routing executes[MSBuildMultiThreadableTask]tasks in-process.