Add a two-player bargain template #794

KeHang-Zhu · 2025-11-07T20:48:59Z

Description

Game Start
↓
[Initialization Stage] – both participants arrive at the bargain stage
├─ Randomly assign roles (buyer / seller)
├─ Randomly generate private valuations (ensure buyer ≥ seller)
├─ Randomly select who moves first (makeFirstMove)
├─ Randomly set maxTurns ∈ [6, 8, 10, 12]
├─ Randomly set chatAllowed = true / false
├─ Randomly set opponentInfo (independent for each participant, 50% probability)
↓
Write to ParticipantAnswer (one record per participant)
Write to PublicData (currentTurn = 1, currentOfferer = first mover)
↓
[Game In preparation]
├─  if both players accept to enter the game
↓
[Game In Progress]
↓
First mover makes an offer*(`processBargainOffer`)
├─ Create a BargainOffer
├─ Add a PENDING transaction to `publicData.transactions`
├─ `currentTurn` unchanged, `currentOfferer` unchanged
↓
Opponent responds (`processBargainResponse`)
├─ Create a BargainOfferResponse
├─ Update transaction status
↓
├─ If accept = true
│   ├─ `isGameOver = true`
│   ├─ `agreedPrice = offer.price`
│   └─ Game ends (agreement reached)
│
└─ If accept = false
├─ `currentTurn += 1`
├─ If `currentTurn > maxTurns`
│   ├─ `isGameOver = true`
│   └─ Game ends (no agreement)
└─ Else
├─ `currentOfferer = previous responder`
└─ Continue to next round

…safety improvements - Problem 1 (Payout): Added bargain payout calculation based on role and agreed price - Problem 2 (UI): Show deal summary inside dialogue panel instead of covering history - Problem 3 (Validation): Added comprehensive valuation range validation [6-12] - Added maximum turns display in action panel - Removed 'as any' casts by adding BargainStageConfigData to StageConfigData union

vivtsai · 2025-11-20T15:59:34Z

frontend/src/services/experiment.manager.ts

      {
        collectionName: 'experiments',
-        experimentTemplate,
+        experimentTemplate: experimentTemplate,


Since the field and the variable are the same name, you can just put experimentTemplate, (as was originally there) instead of experimentTemplate: experimentTemplate

Okay, thanks for explaining. I reverted this

vivtsai · 2025-11-20T16:00:50Z

frontend/tsconfig.json

    "noImplicitAny": true,
-    "module": "es6",
-    "target": "es6",
+    "module": "es2020",


Can you revert this?

vivtsai · 2025-11-20T16:01:19Z

frontend/package-lock.json

+      "version": "0.10.13",
+      "resolved": "https://registry.npmjs.org/@firebase/app/-/app-0.10.13.tgz",
+      "integrity": "sha512-OZiDAEK/lDB6xy/XzYAyJJkaDqmQ+BCtOEPLqFvxWKUz5JbBmej7IiiRHdtiIOD/twW7O5AxVsfaaGA/V1bNsA==",
+      "peer": true,


Is it possible to revert all package-lock.json changes for now?

vivtsai · 2025-11-20T16:01:34Z

frontend/webpack.config.ts


 import CopyWebpackPlugin from 'copy-webpack-plugin';
-import {Configuration} from 'webpack';
+import type {Configuration} from 'webpack';


Can you revert all webpack.config.ts changes?

vivtsai · 2025-11-20T16:03:09Z

functions/src/stages/bargain.endpoints.ts

+          kind: StageKind.BARGAIN,
+          isGameOver: false,
+          currentTurn: null,
+          maxTurns: 8,


Shouldn't maxTurns and other settings here be set based on the bargain stage config (rather than hardcoded)?

These numbers are just placeholder and will be assigned with randomized values when entering the bargain stage

vivtsai · 2025-11-21T06:06:12Z

utils/src/stages/bargain_stage.ts

+  // Current turn number (1-indexed, max = maxTurns), null if game not started
+  currentTurn: number | null;
+  // Maximum number of turns for this game
+  maxTurns: number;


Is this different than what's set in the stage config? (Same question for other fields like chatEnabled).

The value is just a placeholder and will be re-assigned in bargain.utils.ts. I set them to Null here to avoid confusion

If I set it to be undefine or null and assign value later on, there are errors in experiment.manager.ts

vivtsai · 2025-11-21T06:07:05Z

utils/src/stages/bargain_stage.ts

+  // Public ID of participant whose turn it is to make an offer
+  currentOfferer: string | null;
+  // Buyer's public ID
+  buyerId: string | null;


The fields buyerId and sellerId seem redundant with participantRoles?

You are right. I will remove them since participantRoles already have the information.

Removed buyerId and sellerId in all files.

vivtsai · 2025-11-21T06:08:35Z

utils/src/stages/payout_stage.ts

  // For each payout item, only add result to list if item is active;
  // if the payout item has a randomSelectionId,
  // only add the item if it was randomly selected for that participant
+  console.log('[PAYOUT] Processing payout items', {


Please don't add console logs like this in your final PR.

vivtsai · 2025-11-21T06:09:34Z

utils/src/stages/payout_stage.ts

  stageConfigMap: Record<string, StageConfig>,
  publicDataMap: Record<string, StagePublicData>,
  profile: ParticipantProfile, // current participant profile
+  participantAnswerMap?: Record<string, BaseStageParticipantAnswer>,


Don't make this optional

I reverted the changes in calculateDefaultPayoutItemResult, instead, I used the calculateBargainPayoutItemResult function

.gitignore

…public data

…n.utils.ts

KeHang-Zhu added 8 commits October 27, 2025 13:28

add new bargain template

3591fa0

fix the mug in turn making

c037732

fix the validatiom

474c32e

revert some changes

5496108

edit according to Viv

a383f82

add randomization for each cohort

0ad9e64

add a new start game button

1608e72

vivtsai reviewed Nov 21, 2025

View reviewed changes

KeHang-Zhu added 15 commits December 3, 2025 12:06

address issues in bargain.utils.ts

2e902c9

address other issues in bargain.utils.ts

c9f5202

address issues in payout_summary.ts

e4e83ef

address issues in participant.triggers.ts, cleaned up unused trigger

f58a427

Removed buyerId and sellerId in all files.

ce6e6b9

remove makeFirstMove from participant data and create FirstMoveId in …

3071b31

…public data

use the public data log

d13adbe

make participantAnswerMap not optional in payout_stage.ts

5ab2961

revert the change in experimentTemplate

04560d8

removed all console.log in payout.ts, bargain.endpoints.ts and bargai…

5d19869

…n.utils.ts

revert the calculateDefaultPayoutItemResult function

5aa7562

revert the changes in package lock and webpack

24de7d7

revert the changes in package lock of functions and utils

59a743c

Clean up .gitignore formatting

6274e47

revert all changes in package-lock and webpack-lock

f160b1d

KeHang-Zhu force-pushed the feature/bargain branch from 86ab0a2 to f160b1d Compare December 9, 2025 02:30

revert all changes in tsconfig.json

1b8f060

KeHang-Zhu force-pushed the feature/bargain branch from 4435c5f to 1b8f060 Compare December 9, 2025 02:55

cjqian requested a review from jimbojw December 16, 2025 18:19

Add a two-player bargain template #794

Are you sure you want to change the base?

Add a two-player bargain template #794

Uh oh!

Conversation

KeHang-Zhu commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KeHang-Zhu Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KeHang-Zhu commented Nov 7, 2025 •

edited

Loading

KeHang-Zhu Dec 8, 2025 •

edited

Loading