Open
Conversation
tried to resolve PEC-CSS#53 code for categorical nb using map and following gaussian nb convention
Ishwarendra
requested changes
Feb 12, 2023
|
|
||
| ## Example | ||
|
|
||
| ``` |
Collaborator
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```cpp |
| #include "categorical_nb.hpp" | ||
|
|
||
| template<class T> | ||
|
|
Collaborator
There was a problem hiding this comment.
remove extra line. Don't forget to run formatter after changing this.
src/slowmokit/methods/neighbors/categorical_nb/categorical_nb.cpp
Outdated
Show resolved
Hide resolved
| // priors calculated | ||
|
|
||
| std::map<std::string, std::map<T, double>> likelihoods; | ||
| // for any ith label -> n instances -> for each differ probability |
Collaborator
There was a problem hiding this comment.
reframe comment in normal english. No shorthand notations.
Contributor
Author
There was a problem hiding this comment.
reframed , but i have made some changes in code
src/slowmokit/methods/neighbors/categorical_nb/categorical_nb.cpp
Outdated
Show resolved
Hide resolved
src/slowmokit/methods/neighbors/categorical_nb/categorical_nb.cpp
Outdated
Show resolved
Hide resolved
src/slowmokit/methods/neighbors/categorical_nb/categorical_nb.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Ishwarendra Jha <75680424+Ishwarendra@users.noreply.github.com>
Co-authored-by: Ishwarendra Jha <75680424+Ishwarendra@users.noreply.github.com>
Co-authored-by: Ishwarendra Jha <75680424+Ishwarendra@users.noreply.github.com>
Co-authored-by: Ishwarendra Jha <75680424+Ishwarendra@users.noreply.github.com>
Co-authored-by: Ishwarendra Jha <75680424+Ishwarendra@users.noreply.github.com>
…alhotra01/slowmokit into categorical_naive_bayes
Ishwarendra
requested changes
Feb 12, 2023
|
|
||
| #include "../../../core.hpp" | ||
|
|
||
| template<class T> class categoricalNB |
Collaborator
There was a problem hiding this comment.
change to pascal case
Contributor
Author
There was a problem hiding this comment.
changed sir
Comment on lines
29
to
30
| ``` | ||
| cpp |
Collaborator
There was a problem hiding this comment.
Suggested change
| ``` | |
| cpp | |
| ```cpp |
Contributor
Author
There was a problem hiding this comment.
changed sir
uttammittal02
requested changes
Feb 15, 2023
Collaborator
uttammittal02
left a comment
uttammittal02
left a comment
There was a problem hiding this comment.
Do the required changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tried to resolve #53
code for categorical nb using map and following gaussian nb convention