fix : ignore extensions that do not have associated loader class#29
Open
ipranjal wants to merge 1 commit intoPHLAK:masterfrom
Open
fix : ignore extensions that do not have associated loader class#29ipranjal wants to merge 1 commit intoPHLAK:masterfrom
ipranjal wants to merge 1 commit intoPHLAK:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this awesome library ,
I am using this as the configuration engine for scrawler framework https://github.com/scrawler-labs/scrawler
I have seen some shared hosting creating random weird files like .error_log inside config directory , this causes an error
"Class PHLAK\Config\Loaders\Error_log" not found and causes scrawler's boot process to fail
This PR checks if the relevant loader class exists for the file type , If the loader does not exists the file is ignored and other files are successfully loaded