Skip to content

add a fucking delete button finally#18

Merged
RGarrido03 merged 1 commit intomainfrom
FINDIT-163-Delete-finally-a-prod-from-list
May 26, 2025
Merged

add a fucking delete button finally#18
RGarrido03 merged 1 commit intomainfrom
FINDIT-163-Delete-finally-a-prod-from-list

Conversation

@andreribeiro87
Copy link
Member

@andreribeiro87 andreribeiro87 commented May 26, 2025

Summary by CodeRabbit

  • New Features

    • Added the ability to delete products directly from the shopping list with a new trash icon.
  • Improvements

    • Tapping anywhere on a list item now consistently navigates to the product information screen.
    • Enhanced responsiveness and visual feedback for list item presses.
  • Bug Fixes

    • Unified handling of item selection across different list types for a smoother user experience.
  • Chores

    • Removed unused GraphQL queries and mutations to streamline backend operations.

@coderabbitai
Copy link

coderabbitai bot commented May 26, 2025

Walkthrough

The changes introduce product deletion functionality in the shopping list, unify and require the onPress handler for all list item types, and streamline press handling in the ListItem component. Additionally, several unused GraphQL queries and mutations are removed from the codebase, including their types and document nodes.

Changes

File(s) Change Summary
app/(tabs)/index.tsx Added onPress handler to List for navigation to /productInfo with selected item's ean.
app/(tabs)/shopping-list.tsx Added GraphQL mutation and UI for deleting products from the shopping list; updated icon and handler accordingly.
components/ListItem.tsx Replaced conditional wrappers with unified Pressable; made onPress required for all item types.
components/ui/list/list.tsx Added required onPress callback to InfoProps and ExtendedProps types.
graphql/gql.ts, graphql/graphql.ts Removed types, document nodes, and support for three GraphQL operations: CurrentSupermarketListWithProducts, GetRecommendations, and UpsertProductFromList.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ShoppingListScreen
    participant ApolloClient
    participant Backend

    User->>ShoppingListScreen: Presses trash icon on product
    ShoppingListScreen->>ApolloClient: Call DELETE_PRODUCT_FROM_LIST mutation
    ApolloClient->>Backend: Send mutation with list ID and product EAN
    Backend-->>ApolloClient: Respond with deletion result
    ApolloClient->>ShoppingListScreen: Refetch product list query
    ShoppingListScreen->>User: UI updates to remove product
Loading

Poem

In the warren of code, a tidy-up day,
Old queries hop out, making room for new play.
Now with a tap, you can whisk things away—
A shopping list lighter, with bunnies at bay!
🐇✨

Press, delete, and onward we go,
In a garden of features that continues to grow!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between c2703a6 and 91f74e6.

📒 Files selected for processing (6)
  • app/(tabs)/index.tsx (1 hunks)
  • app/(tabs)/shopping-list.tsx (4 hunks)
  • components/ListItem.tsx (5 hunks)
  • components/ui/list/list.tsx (2 hunks)
  • graphql/gql.ts (0 hunks)
  • graphql/graphql.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • graphql/gql.ts
  • graphql/graphql.ts

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

🚀 Expo preview is ready!

  • Project → client-app
  • Platforms → android, ios
  • Scheme → findit
  • Runtime Version → 1.13.0
  • More info

Learn more about 𝝠 Expo Github Action

Copy link
Member

@RGarrido03 RGarrido03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amo, a fazer o que já havia ter sido feito há muito, god bless u, muah

@RGarrido03 RGarrido03 merged commit 34374e3 into main May 26, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants