Skip to content

FINDIT-164 Fix navigation page with no list chosen#22

Merged
andreribeiro87 merged 3 commits intomainfrom
FINDIT-164-Fix-navigation-page-with-no-list-chosen
May 28, 2025
Merged

FINDIT-164 Fix navigation page with no list chosen#22
andreribeiro87 merged 3 commits intomainfrom
FINDIT-164-Fix-navigation-page-with-no-list-chosen

Conversation

@RGarrido03
Copy link
Member

@RGarrido03 RGarrido03 commented May 28, 2025

Conto os dias para mim
Com a mala arrumada
Já quase não cabia
A saudade acumulada
do azul, vejo o jardim
Mesmo por trás da asa
Mãe olha à janela
Que eu 'tou a chegar a casa
Que eu 'tou a chegar a casa
Que eu 'tou a chegar a casa
Que eu 'tou a chegar a casa
Por mais que possa parecer
Eu nunca vou pertencer àquela cidade
O mar de gente, o Sol diferente
O monte de betão não me provoca nada
Não me convoca casa
Porque eu vim de longe
Eu vim do meio do mar
Do coração do oceano
Eu tenho a minha vida inteira
O meu caminho eu faço a pensar em regressar
À minha casa, é ilha, paz, Madeira
Se eu te explicar, palavra a palavra
Nunca vais entender a dor que me cala
A solidão que assombra a hora da partida
Carrego o sossego de poder voltar
Mãe olha à janela que eu 'tou a chegar
Por mais que possa parecer
Eu nunca vou pertencer àquela cidade
O mar de gente, o Sol diferente
O monte de betão não me provoca nada
Não me convo' ah ah ah ah ah ahh uh uh uh
O mar de gente, o Sol diferente
O monte de betão não me provoca nada
Não me convoca casa

Summary by CodeRabbit

  • Bug Fixes

    • Improved navigation screen behavior by prompting users to create or select a shopping list before starting in-store navigation if none is selected.
  • Chores

    • Cleaned up unused variables, imports, and commented code across multiple components for improved maintainability.
    • Updated build configuration to explicitly set Android production builds to generate APK files.

RGarrido03 and others added 3 commits May 29, 2025 00:04
Co-authored-by: Violeta Ramos <VioletaR@users.noreply.github.com>
Co-authored-by: Violeta Ramos <VioletaR@users.noreply.github.com>
Co-authored-by: Violeta Ramos <VioletaR@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented May 28, 2025

Walkthrough

The changes remove unused variables, comments, and imports across several components, streamline effect dependencies, and add a user prompt in the navigation screen when no shopping list is selected. Additionally, the Android production build configuration is updated to specify APK as the build type.

Changes

File(s) Change Summary
app/(tabs)/navigation.tsx Removed unused id from useAuth(), updated effect dependencies, added prompt for missing list.
app/navigation-in-store/index.tsx Removed unused import, deleted unused/commented code, simplified Kalman filter logic.
app/productSearch/index.tsx Removed unused userId from destructuring useAuth().
components/ListItem.tsx Deleted unused ItemWrapper constant.
utils/navigation-in-store.ts Removed commented-out debug log and placeholder comment.
eas.json Added "android": { "buildType": "apk" } to production build profile.

Poem

In code we hop, with paws so neat,
Unused lines trimmed, our work complete.
A prompt appears when lists are bare,
And APK builds now everywhere!
With every change, we leap ahead—
Cleaner code, less dread!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 560a245 and ebc17f6.

📒 Files selected for processing (6)
  • app/(tabs)/navigation.tsx (3 hunks)
  • app/navigation-in-store/index.tsx (0 hunks)
  • app/productSearch/index.tsx (1 hunks)
  • components/ListItem.tsx (0 hunks)
  • eas.json (1 hunks)
  • utils/navigation-in-store.ts (0 hunks)
💤 Files with no reviewable changes (3)
  • utils/navigation-in-store.ts
  • components/ListItem.tsx
  • app/navigation-in-store/index.tsx

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubefindit
Copy link

Passed Quality Gate passed

Issues

Measures

Project ID: PI-FindIt_client-app_6ea8cb86-d2f7-4f01-84cb-a3c7850e949f

View in SonarQube

@github-actions
Copy link

🚀 Expo preview is ready!

  • Project → client-app
  • Platforms → android, ios
  • Scheme → findit
  • Runtime Version → 1.17.0
  • More info

Learn more about 𝝠 Expo Github Action

@andreribeiro87 andreribeiro87 merged commit e47dd19 into main May 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants