-
Notifications
You must be signed in to change notification settings - Fork 247
chore: bump chumsky from 0.11.2 to 0.12.0 #5641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [chumsky](https://github.com/zesterer/chumsky) from 0.11.2 to 0.12.0. - [Release notes](https://github.com/zesterer/chumsky/releases) - [Changelog](https://github.com/zesterer/chumsky/blob/main/CHANGELOG.md) - [Commits](https://github.com/zesterer/chumsky/commits/0.12) --- updated-dependencies: - dependency-name: chumsky dependency-version: 0.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
@claude please fix |
|
Claude finished @max-sixty's task in 39m 35s —— View job Fixing chumsky 0.12.0 Upgrade ✅
Root cause: chumsky 0.12.0 introduces a new Fix:
Changes made:
|
…lity chumsky 0.12.0 introduces a new SpanWrap trait with a with_span method that conflicts with the existing WithErrorInfo::with_span method. Use fully qualified syntax to resolve the ambiguity. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Maximilian Roos <max-sixty@users.noreply.github.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Maximilian Roos <max-sixty@users.noreply.github.com>
|
@claude should we be using the |
|
Claude finished @max-sixty's task in 1m 48s —— View job Investigating chumsky 0.12.0
|
| Trait | Purpose | Example Use |
|---|---|---|
chumsky's SpanWrap::with_span |
Wrapping AST nodes with span info | expr.with_span(span) → (Expr, Span) |
Our WithErrorInfo::with_span |
Adding span info to Error types | error.with_span(span) → Error { span: ... } |
Our current usage is correct. In both lexer/mod.rs (line 53) and interpolation.rs (line 66), we're adding span information to Error types, not AST nodes:
// lexer/mod.rs:53 - Adding span to an Error
WithErrorInfo::with_span(
Error::new(Reason::Unexpected { ... }),
Some(crate::span::Span { ... }),
)
// interpolation.rs:66 - Adding span to an Error
WithErrorInfo::with_span(Error::new_simple(message), Some(span))Chumsky's spanned combinator and SpanWrap::with_span are designed for wrapping parser output (AST nodes) with spans, not for error construction.
Recommendation
No change needed. The current fix using fully qualified syntax WithErrorInfo::with_span(...) is the correct approach. Chumsky's .with_span method is for a different use case (AST node spanning, not error spanning).
If we wanted to simplify the disambiguation, an alternative would be to rename our method (e.g., to with_error_span), but this would be a larger refactoring that isn't necessary—the current approach is clear and correct.
|
Bumps chumsky from 0.11.2 to 0.12.0.
Changelog
Sourced from chumsky's changelog.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)