【Hackathon 10th Spring No.2】Add schema parser and related functionality for Torch compatibility by gouzil · Pull Request #77938 · PaddlePaddle/Paddle

gouzil · 2026-02-16T14:27:44Z

PR Category

Execute Infrastructure

PR Types

Improvements

Description

PaddlePaddle/community#1210 的实现

为 TORCH_LIBRARY 注册机制添加 schema 支持, 修改了 OperatorRegistry 的 schema 数据结构
支持参数默认值和指定参数赋值
支持 schema 的 alias 表示
增加 schema 解析器和 schema type 解析器

单测调整

~~torch_library_test 移出需要 gpu~~ 暂时还不行，原因可以查看 https://github.com/PaddlePaddle/Paddle/actions/runs/22081133427/job/63808517292?pr=77938 运行日志
新增 schema_parser_type_test 用于测试 schema 解析器

TODO

cinn 和 paddle/pir/src/core/utils.cc 都用到了相同的 hash_combine 函数，可以考虑提到一个通用的地方
添加一些 e2e 的测试 6676b1c

初步验证了 https://github.com/PFCCLab/paddlecodec

是否引起精度变化

否

paddle-bot · 2026-02-16T14:27:52Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copilot

Pull request overview

This PR adds comprehensive schema parser functionality to the TORCH_LIBRARY registration mechanism, enabling PyTorch-compatible operator definitions with full type information, default values, keyword arguments, and alias annotations. This is part of the Hackathon 10th Spring No.2 task and significantly enhances the compatibility layer between PaddlePaddle and PyTorch.

Changes:

Implemented schema parsing infrastructure including FunctionSchemaParser and SchemaTypeParser to parse PyTorch-style operator schemas
Extended FunctionArgs to support named/keyword arguments and automatic argument normalization based on parsed schemas
Added comprehensive type system (FunctionSchema, Argument, AliasInfo, Type hierarchy) to represent parsed schema information

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/cpp/compat/torch_library_test.cc	Added 400+ lines of comprehensive tests for schema parsing, including default values, keyword arguments, optional types, tuples, and variadic functions
test/cpp/compat/schema_parser_type_test.cc	New test file (206 lines) specifically for testing schema type parser edge cases and torchcodec-like schemas
test/cpp/compat/CMakeLists.txt	Moved torch_library_test from GPU-only (nv_test) to general (cc_test) and added schema_parser_type_test
paddle/phi/api/include/compat/torch/library.h	Added schema binding to CppFunction, keyword argument support in FunctionArgs, and normalize_args_by_schema logic
paddle/phi/api/include/compat/torch/library.cpp	Updated OperatorRegistry to parse and bind schemas to implementations
paddle/phi/api/include/compat/torch/csrc/jit/function_schema_parser.h/cpp	New 574-line schema parser implementation handling full PyTorch schema grammar
paddle/phi/api/include/compat/torch/csrc/jit/schema_type_parser.h/cpp	New 240-line type parser for parsing schema types including tuples, optionals, and alias annotations
paddle/phi/api/include/compat/torch/csrc/jit/schema_parser_defs.h	Constants and macros for schema parsing (type names, keywords, characters)
paddle/phi/api/include/compat/ATen/core/function_schema.h/cpp	New FunctionSchema and Argument classes to represent parsed schemas
paddle/phi/api/include/compat/ATen/core/jit_type_base.h	Base Type class hierarchy with SingletonOrSharedTypePtr for type system
paddle/phi/api/include/compat/ATen/core/jit_type.h	Concrete type implementations (TensorType, IntType, FloatType, etc.) and schema-specific types
paddle/phi/api/include/compat/ATen/core/alias_info.h	AliasInfo class for representing aliasing metadata in schemas
paddle/phi/api/include/compat/ATen/core/type_ptr.h	SingletonTypePtr wrapper for singleton type instances
paddle/phi/api/include/compat/ATen/core/functional.h	Utility functions (fmap, filter) for working with collections
paddle/phi/api/include/compat/CMakeLists.txt	Updated build to include new schema parser source files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-16T14:34:07Z

+
+      const size_t idx = it->second;
+      if (assigned[idx]) {
+        throw std::runtime_error("Argument `" + name + "` is already provided");


The error message "Argument name is already provided" could be more helpful by specifying whether the argument was provided both positionally and by keyword. Consider changing to: "Argument " + name + " provided both positionally and as keyword argument"

Suggested change

throw std::runtime_error("Argument `" + name + "` is already provided");

throw std::runtime_error("Argument `" + name +

"` provided both positionally and as keyword argument");

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-16T15:11:51Z

+                                     std::move(*alias_info))
+                               : nullptr),
+        kwarg_only_(kwarg_only) {
+    // this is an softly-enforced invariant for out arguments.


The comment contains a grammatical error. It should be "This is a softly-enforced invariant" instead of "this is an softly-enforced invariant". The article "an" should be "a" before "softly".

Suggested change

// this is an softly-enforced invariant for out arguments.

// This is a softly-enforced invariant for out arguments.

SigureMo · 2026-02-16T17:56:22Z

@gouzil 测试哈，这个 PR 当下 🐁

SigureMo

补充两条行内意见，主要是 named kwargs 输出可测性和稳定性建议。\n\n使用的是 gpt-5.3-codex with @codex by using gh-llm；当前只是 gh-llm 开发测试。

codecov-commenter · 2026-02-17T04:22:26Z

Codecov Report

❌ Patch coverage is 97.53695% with 25 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@63eaee1). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...e/compat/torch/csrc/jit/function_schema_parser.cpp	94.62%	18 Missing ⚠️
...i/api/include/compat/ATen/core/function_schema.cpp	93.33%	6 Missing ⚠️
...e/phi/api/include/compat/ATen/core/jit_type_base.h	98.64%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #77938   +/-   ##
==========================================
  Coverage           ?   97.53%           
==========================================
  Files              ?       11           
  Lines              ?     1015           
  Branches           ?        0           
==========================================
  Hits               ?      990           
  Misses             ?       25           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

SigureMo · 2026-02-17T07:38:55Z

+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.


参考 torch 的代码记得添加声明

// #The file has been adapted from pytorch project // #Licensed under BSD-style license - // https://github.com/pytorch/pytorch/blob/main/LICENSE

参考 ivalue.h

参考 #78590 改一下声明

另外，paddlecodec 那边目前卡在哪里了？

另外，paddlecodec 那边目前卡在哪里了？

c++ 部分的还有一些 torch::tensor 不支持的，python 部分正在

PFCCLab/paddlecodec#3

不需要全部恢复，这不是这个 PR 需要考虑的问题，只需要考虑这个 PR 需要考虑的部分即可

这个 PR 合入之后 PFCCLab/paddlecodec#3 就可以合入的话，那我觉得这个 PR 目前已经达到合入标准了

PFCCLab/paddlecodec#3 依赖 #78521 吗？

PFCCLab/paddlecodec#3 依赖 #78521 吗？

有的 PFCCLab/paddlecodec@c348bb8

@gouzil 调试呢，通知处理这块可能会有些抖动，一些信息可能重复处理

…ma_parser_torch_compatibility

SigureMo

有能让 paddlecodec 减少 diff 的 PR 么？

meta-pytorch/torchcodec@main...PFCCLab:paddlecodec:paddle

…dd corresponding test cases

…ma_parser_torch_compatibility

SigureMo · 2026-03-22T05:39:17Z

但 TORCH_LIBRARY_IMPL 中 def(..., fn) 的误用语义还没修：

退下吧喵子

SigureMo · 2026-03-22T10:43:38Z

有能让 paddlecodec 减少 diff 的 PR 么？

meta-pytorch/torchcodec@main...PFCCLab:paddlecodec:paddle

别忘了这个

…ma_parser_torch_compatibility

… hash symbols

…ma_parser_torch_compatibility

SigureMo · 2026-04-04T18:00:34Z

不支持的可以考虑删了

这个怎么还没改？

@ShigureNyako 来 review 一下，没有问题就沿着这个线用犀利的语气骂 @gouzil 两句 ~~（测试新版 worktree 功能）~~（看来测不了，这个 PR 是旧的 session）

SigureMo · 2026-04-04T18:03:05Z

+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.


不需要全部恢复，这不是这个 PR 需要考虑的问题，只需要考虑这个 PR 需要考虑的部分即可

这个 PR 合入之后 PFCCLab/paddlecodec#3 就可以合入的话，那我觉得这个 PR 目前已经达到合入标准了

PFCCLab/paddlecodec#3 依赖 #78521 吗？

…ma_parser_torch_compatibility

…nd clean code

…ma_parser_torch_compatibility

…tionSchema in function_schema_parser and library headers

SigureMo · 2026-04-08T06:17:18Z

@gouzil 等 1-2 天后 nightly 包出来后，关注下 PFCCLab/paddlecodec#3，推动那边合入

gouzil added 2 commits February 16, 2026 20:46

Add schema parser and related functionality for Torch compatibility

734b992

support keyword specification

9a0654e

Copilot AI review requested due to automatic review settings February 16, 2026 14:27

paddle-bot Bot added the contributor External developers label Feb 16, 2026

Copilot started reviewing on behalf of gouzil February 16, 2026 14:28 View session

gouzil changed the title ~~【Hackathon 10th Spring No.2】Add schema parser and related functionality for Torch compatibility~~ 【WIP】【Hackathon 10th Spring No.2】Add schema parser and related functionality for Torch compatibility Feb 16, 2026

Copilot AI reviewed Feb 16, 2026

View reviewed changes

clean code

26b319d

gouzil requested a review from Copilot February 16, 2026 15:05

Copilot started reviewing on behalf of gouzil February 16, 2026 15:05 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

SigureMo reviewed Feb 16, 2026

View reviewed changes

Comment thread paddle/phi/api/include/compat/torch/library.h

Comment thread paddle/phi/api/include/compat/torch/library.h

fix hash_combine

15b3ffc

SigureMo reviewed Feb 17, 2026

View reviewed changes

gouzil added 3 commits February 17, 2026 19:11

add license

642371a

torch_library_test move use WITH_GPU

1feb656

add Duplicate keyword test

2be5bb2

luotao1 mentioned this pull request Feb 21, 2026

【Hackathon 10th】开源贡献个人挑战赛 · 春节特别季 #77429

Open

gouzil added 8 commits February 21, 2026 19:42

2025 -> 2026

c191ce0

add license

d91263a

add more test

02ef81b

add more test

028b22a

add more test

18ffdb0

Merge branch 'develop' of github.com:gouzil/Paddle into feat/add_sche…

cda5bb5

…ma_parser_torch_compatibility

add more test

9dc6724

fix kwargs mapping error

6676b1c

gouzil added 6 commits March 2, 2026 13:35

add license

b961da6

clean include

92f5fd2

fix: add cmakelist

474e437

ignore test

bb0be80

Merge branch 'develop' of github.com:gouzil/Paddle into feat/add_sche…

fafb22c

…ma_parser_torch_compatibility

fix review

7c9cb61

gouzil requested a review from ShigureNyako March 17, 2026 01:45

gouzil changed the title ~~【WIP】【Hackathon 10th Spring No.2】Add schema parser and related functionality for Torch compatibility~~ 【Hackathon 10th Spring No.2】Add schema parser and related functionality for Torch compatibility Mar 22, 2026

SigureMo reviewed Mar 22, 2026

View reviewed changes

gouzil added 2 commits March 22, 2026 13:30

fix the AliasInfo hash function to support unordered containers and a…

f2b07b7

…dd corresponding test cases

Merge branch 'develop' of github.com:gouzil/Paddle into feat/add_sche…

ff036b2

…ma_parser_torch_compatibility

gouzil added 3 commits March 24, 2026 09:15

clean glog

ac42022

Merge branch 'develop' of github.com:gouzil/Paddle into feat/add_sche…

d10cf91

…ma_parser_torch_compatibility

Merge branch 'develop' of github.com:gouzil/Paddle into feat/add_sche…

594330d

…ma_parser_torch_compatibility

gouzil mentioned this pull request Apr 4, 2026

Reduce the diff with the pytorch:main branch PFCCLab/paddlecodec#3

Merged

gouzil added 2 commits April 5, 2026 00:58

Modify the header comment format of the file and remove the redundant…

f620ef7

… hash symbols

Merge branch 'develop' of github.com:gouzil/Paddle into feat/add_sche…

f4936a9

…ma_parser_torch_compatibility

SigureMo reviewed Apr 4, 2026

View reviewed changes

gouzil added 2 commits April 5, 2026 15:19

Merge branch 'develop' of github.com:gouzil/Paddle into feat/add_sche…

5cad663

…ma_parser_torch_compatibility

Refactor license comments in compatibility headers and source files a…

6e22c7c

…nd clean code

SigureMo mentioned this pull request Apr 6, 2026

[Cpp API Compatibility] Delete useless code and rename test files #78580

Merged

gouzil added 2 commits April 7, 2026 23:46

Merge branch 'develop' of github.com:gouzil/Paddle into feat/add_sche…

b5e17a0

…ma_parser_torch_compatibility

[Cpp API Compatibility] Update FunctionSchema references to c10::Func…

d49a95a

…tionSchema in function_schema_parser and library headers

SigureMo approved these changes Apr 7, 2026

View reviewed changes

risemeup1 approved these changes Apr 8, 2026

View reviewed changes

SigureMo merged commit a35f006 into PaddlePaddle:develop Apr 8, 2026
145 of 150 checks passed

SigureMo deleted the feat/add_schema_parser_torch_compatibility branch April 8, 2026 06:20

	throw std::runtime_error("Argument `" + name + "` is already provided");
	throw std::runtime_error("Argument `" + name +
	"` provided both positionally and as keyword argument");

	// this is an softly-enforced invariant for out arguments.
	// This is a softly-enforced invariant for out arguments.

Conversation

gouzil commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

单测调整

TODO

是否引起精度变化

Uh oh!

paddle-bot Bot commented Feb 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

SigureMo commented Feb 16, 2026

Uh oh!

SigureMo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SigureMo left a comment

Choose a reason for hiding this comment

Uh oh!

SigureMo commented Mar 22, 2026

Uh oh!

SigureMo commented Mar 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SigureMo Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SigureMo commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

gouzil commented Feb 16, 2026 •

edited

Loading

codecov-commenter commented Feb 17, 2026 •

edited

Loading

SigureMo Apr 6, 2026 •

edited

Loading

SigureMo commented Apr 8, 2026 •

edited

Loading