Transfer applied resource packs#1495
Draft
Gerrygames wants to merge 3 commits intoPaperMC:dev/3.0.0from
Draft
Conversation
Member
|
Is it worth making this a generic record storage in case additional fields could be transferred in the future? record TransferSession(Collection<ResourcePackInfo> appliedPacks) {}May just make it easier to add onto in the future. |
Member
|
The size of a cookie is fairly limited, if we want to store additional info it would make more sense to send additional cookies, IMHO; I guess you could make it more abstracted out, but, we'd still be sending separate cookies out, etc; so, I'm not 100% sure entirely what we'd get trying to combine stuff too much (other than a bunch more code to maintain) |
Gerrygames
force-pushed
the
feat/applied-resource-packs-transfer
branch
from
5ca718b to
93dc20f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.