Increase TabComplete max char limit to respect command block character limit#1681
Draft
ZoeWithTheE wants to merge 1 commit intoPaperMC:dev/3.0.0from
Draft
Increase TabComplete max char limit to respect command block character limit#1681ZoeWithTheE wants to merge 1 commit intoPaperMC:dev/3.0.0from
ZoeWithTheE wants to merge 1 commit intoPaperMC:dev/3.0.0from
Conversation
…r limit This change increases the TabComplete limit in order to fix the now broken pasting of larger commands into command blocks after Mojang's change to the way Tab Complete works. It has been increased to 32767 from 2048, and this increase has no negative impact on performance, stability, or protocol compliance. Mojang clients and servers already allow command strings up to 32767 characters, and this update brings Velocity in line with the vanilla protocol. This prevents unnecessary disconnections when pasting valid command block contents while retaining full protection against malformed packets.
Author
|
No open issue for this bug. This is the error being observed: PasteBin velocity logs |
Member
|
We and paper intentionally limited this in the past in order to restrict ongoing DoS attacks, I do ponder if it makes any sense to move this restriction elsewhere, I guess some limited adventage with brig is that it might be able to deal with this stuff a bit smarter than the older bukkit command system so maybe this wasn't too much of a problem for us, outside of network buffers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change increases the TabComplete limit in order to fix the now broken pasting of larger commands into command blocks after Mojang's change to the way Tab Complete works. It has been increased to 32767 from 2048, and this increase has no negative impact on performance, stability, or protocol compliance.
Mojang clients and servers already allow command strings up to 32767 characters, and this update brings Velocity in line with the vanilla protocol. This prevents unnecessary disconnections when pasting valid command block contents while retaining full protection against malformed packets.