Implementing FieldSet.from_croco() #2450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that users have access to UV even if there's also a W field
Using XLinear interpolation gives gives much better results for the tutorial (particles stay closer to initial depth). This was also done in v3
As the v3 interpolation turns out to be wrong too
2 tasks
erikvansebille
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #2447 by a dying another method
FieldSet.from_croco()to load in crocs fields.Different from how crocs interpolation was done in v3, there is no more 'under-the-hood' conversion and/or magic. Instead, there is a new kernel specifically for croco (in kernels/sigmagrid.py) that transparently shows how the advection and interpolation are done on croco grids