Using from_sgrid_conventions for simple_UV_dataset throughout #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
approved these changes
Jan 9, 2026
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Thanks or the clarifications - LGTM ! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a
FieldSet.from_sgrid_conventions()method, we can clean up many of the tutorials that rely on thesimple_UV_datasetby simplifying the fieldset creation.This requires the sgrid metadata to be attached to
simple_UV_dataset, which this PR also implementsAnother change is that
FieldSet.from_sgrid_conventions()now always return aFieldSet.UVifUandVare present, irrespective of whetherWis present (see #2453 (comment))This PR also cleans AdvectEE_NestedGrids Kernel now that #2143 has been merged