Speedup export of skill tree and regenerating files #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4x speed improvement on passive tree generation and 2x speed improvement on regenerating files We now pass a manifest file to the ooz extractor so we are no longer limited by the cmd character limit and can batch many previous calls into a single call This cuts our regen of files from 7 cmd calls taking 30s to 2 cmd calls taking 15s For the passive tree it cuts it from 18 cmd calls taking 45s to 2 cmd calls taking 11s Also removed the old logic for non dat64 files as we don't need it any more In the passive tree file I batched together all the asset extraction calls and removed a whole bunch of prints to the console so now the console isn't flooded
LocalIdentity
added
pob1
Wires77
reviewed
Dec 16, 2025
Wires77
approved these changes
Dec 16, 2025
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Dec 17, 2025
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Dec 17, 2025
…9402) Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4x speed improvement on passive tree generation and 2x speed improvement on regenerating files
We now pass a manifest file to the ooz extractor so we are no longer limited by the cmd character limit and can batch many previous calls into a single call
This cuts our regen of files from 7 cmd calls taking 30s to 2 cmd calls taking 15s
For the passive tree it cuts it from 18 cmd calls taking 45s to 2 cmd calls taking 11s
Also removed the old logic for non dat64 files as we don't need it any more
In the passive tree file I batched together all the asset extraction calls and removed a whole bunch of prints to the console so now the console isn't flooded