Skip to content

Re-add 'HTML_NAMESPACE' (used in tests)#28

Open
njam wants to merge 1 commit into
Pauan:masterfrom
njam:html-namespace
Open

Re-add 'HTML_NAMESPACE' (used in tests)#28
njam wants to merge 1 commit into
Pauan:masterfrom
njam:html-namespace

Conversation

@njam

@njam njam commented Feb 2, 2020

Copy link
Copy Markdown

Just making the code compile

cargo check --all-targets

The const HTML_NAMESPACE is used in the same file, in the tests module.
Not sure if you prefer defining the constant in the tests module, to avoid it being "dead code"?

@Pauan Pauan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah I'd rather just change the tests to use html! instead.

@njam

njam commented Feb 2, 2020

Copy link
Copy Markdown
Author

Hm, the tests are using DomBuilder, but html! is creating Dom.
I've now replaced DomBuilder::new(create_element_ns(...)) with DomBuilder::new_html(...), does that make sense?

@njam

njam commented Feb 2, 2020

Copy link
Copy Markdown
Author

btw, how are you running the tests? :D

I tried running tests with "wasm-bindgen-test" in Chrome, and got 3/6 failing tests.

@Pauan

Pauan commented Oct 21, 2021

Copy link
Copy Markdown
Owner

Oh, I'm sorry, I somehow missed this issue. I don't actually run any of the tests, I just use them for compile-time type checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants