UI and Internal changes - now works on 'M' macOS and lets user select baud rate etc. #22
Open
IanBUK wants to merge 71 commits intoPaulStoffregen:masterfrom
Open
UI and Internal changes - now works on 'M' macOS and lets user select baud rate etc. #22IanBUK wants to merge 71 commits intoPaulStoffregen:masterfrom
IanBUK wants to merge 71 commits intoPaulStoffregen:masterfrom
Conversation
Need way of setting max/actual height for panel.
Can see what the raw data is and that the line endings aren't being respected.
Add Baud rate setter to UI.
…gle Resp. Principle.
read from port doesn't yet use line endings setting.
doesn't work
doesn't quite work yet.
Parsing wasn't allowing a ' ' character.
some commented out colouring play-code in visualize.c
… pull before I removed the .idea folder
…ve calibration data
…now warns about the gl.... functions, that they've been deprecated. We may need to do a mac specific modern visualizer.c replacement
Author
|
Hi! Just checking in to see if there's anything I can do to help move this PR forward. Happy to adjust anything as needed. |
Author
|
@PaulStoffregen - is there anything I can do to help move this PR forward? Would squashing the merge down to a single commit make it easier for you to reject/approve? |
Author
|
@PaulStoffregen - I'm guessing this repo is abandoned? |
Copy changes across from subfolder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added:
Option to set the baud rate.
Option to specify the line ending.
Pause button.
'Received Data' panel, which shows: a. The floats from the 'Raw:' messages. b. 'Orientation' data received from an 'Ori:' message, which has three floats containing yaw, roll, pitch.
Messages panel, used to churn out messages. 'Gaps' data is shown when it has changed from the last data update.
Internal changes
logging.cThe code now builds a log as it's going: log.txt. To add new lines to the log, use the logMessage function. debugPrint can be used for listing out the content of a const unsigned char * to log.txt. logTerminalSettings logs some members of an termios instance.
serialdata.cI've split serialdata.c into serialdata.c, serialdata.messaging.c and serialdata.parsing.c - as I added new callback routes I found the class was getting too large for my brain.
I've updated the reading of new lines from the serial port - it kept failing as is. This might be to macOS changes - I've no reason to think the code itself was wrong.
gui.cppI've split the UI building code out into separate function. When adding the panels, the existing function grew to a few hundred lines.
CallbacksWhen new Raw, Cal1, Cal2 or Ori messages are read from the console, they're now sent back to gui.cpp using callbacks.