Skip to content

Support MariaDB VECTOR during CDC#4454

Merged
ilidemi merged 6 commits into
mainfrom
mysql/task-826
Jun 24, 2026
Merged

Support MariaDB VECTOR during CDC#4454
ilidemi merged 6 commits into
mainfrom
mysql/task-826

Conversation

@ilidemi

@ilidemi ilidemi commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Maria binlog encodes vectors as MYSQL_TYPE_VARCHAR and gives us string while MySQL comes as []byte

Resolves DBI-826

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The MongoDB container setup hit a "not primary" race condition where db.createUser ran before the replica set finished electing a primary after rs.initiate(), an environmental flake unrelated to the MySQL-focused branch.
Confidence: 0.95

✅ Automatically retrying the workflow

View workflow run

Comment thread flow/connectors/mysql/qvalue_convert_test.go Outdated
Comment thread flow/e2e/clickhouse_mysql_test.go Outdated
@ilidemi ilidemi changed the title [WIP] 826 MariaDB VECTOR: CDC string-arm not handled Support MariaDB VECTOR during CDC Jun 24, 2026
@ilidemi ilidemi marked this pull request as ready for review June 24, 2026 04:02
@ilidemi ilidemi requested a review from a team as a code owner June 24, 2026 04:02
@claude

claude Bot commented Jun 24, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The flow/e2e package hit its 20-minute package timeout with no single hung test (longest-running was only ~2m) and no deadlock in the dump, with the still-running tests being unrelated PostgreSQL e2e cases rather than the PR's MariaDB VECTOR change — indicating the known-flaky, high-concurrency suite simply overran its wall-clock budget.
Confidence: 0.82

✅ Automatically retrying the workflow

View workflow run

@pfcoperez pfcoperez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd change the PR title (which is preserved in the commit history) because the type is not only supported in MariaDB VECTOR but also in MySQL 9.0+, according to the tests conditions themselves, and they use the same format.

Correction on my comment: I see we treat a different underlying type for MySQL.

Comment thread flow/connectors/mysql/qvalue_convert.go Outdated
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2332 1 2331 220
View the top 1 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/connectors/postgres::TestRunPipeline_FilterStripsLines
Stack Traces | 0s run time
=== RUN   TestRunPipeline_FilterStripsLines
    pgdump_schema_test.go:262: unexpected error: src failed: signal: killed
        stderr:
--- FAIL: TestRunPipeline_FilterStripsLines (0.00s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The fully self-contained test TestRunPipeline_FilterStripsLines failed with "src failed: signal: killed" because its trivial local printf subprocess was SIGKILLed externally (OOM/resource exhaustion on the heavily-parallel runner), not due to any logic bug—and it failed in only 1 of 5 matrix jobs on an unrelated MySQL PR.
Confidence: 0.88

✅ Automatically retrying the workflow

View workflow run

@ilidemi ilidemi merged commit c21a707 into main Jun 24, 2026
19 of 20 checks passed
@ilidemi ilidemi deleted the mysql/task-826 branch June 24, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants