Skip to content

Decode BINARY(N) as Bytes on the binlog-metadata add-column path#4457

Open
ilidemi wants to merge 3 commits into
mainfrom
mysql/task-856
Open

Decode BINARY(N) as Bytes on the binlog-metadata add-column path#4457
ilidemi wants to merge 3 commits into
mainfrom
mysql/task-856

Conversation

@ilidemi

@ilidemi ilidemi commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Resolves DBI-856

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2336 1 2335 197
View the top 1 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/connectors/postgres::TestRunPipeline_FilterStripsLines
Stack Traces | 0.04s run time
=== RUN   TestRunPipeline_FilterStripsLines
    pgdump_schema_test.go:262: unexpected error: src failed: signal: killed
        stderr:
--- FAIL: TestRunPipeline_FilterStripsLines (0.04s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The unit test TestRunPipeline_FilterStripsLines failed because its trivial printf subprocess was SIGKILLed ("src failed: signal: killed", empty stderr) under high test concurrency — an OOM/resource flake unrelated to the branch's MySQL binlog changes.
Confidence: 0.92

✅ Automatically retrying the workflow

View workflow run

Comment thread flow/connectors/mysql/qvalue_convert_test.go Outdated
@ilidemi ilidemi changed the title [WIP] 856 decode BINARY(N) as Bytes on the binlog-metadata add-column path Decode BINARY(N) as Bytes on the binlog-metadata add-column path Jun 24, 2026
@ilidemi ilidemi marked this pull request as ready for review June 24, 2026 03:55
@ilidemi ilidemi requested a review from a team as a code owner June 24, 2026 03:55
@claude

claude Bot commented Jun 24, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant