Skip to content

Support null-terminated strings in MySQL DDL#4459

Merged
ilidemi merged 4 commits into
mainfrom
mysql/task-859
Jun 24, 2026
Merged

Support null-terminated strings in MySQL DDL#4459
ilidemi merged 4 commits into
mainfrom
mysql/task-859

Conversation

@ilidemi

@ilidemi ilidemi commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Trailing \x00 is the most common case of parse failures and also the most silly one.

Closes DBI-859

Comment thread flow/connectors/mysql/cdc.go Outdated
@ilidemi ilidemi changed the title [WIP] 859 trailing \0 on DDL breaks the TiDB parser Support null-terminated strings in MySQL DDL Jun 24, 2026
@ilidemi ilidemi marked this pull request as ready for review June 24, 2026 05:34
@ilidemi ilidemi requested a review from a team as a code owner June 24, 2026 05:34
@claude

claude Bot commented Jun 24, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2345 2 2343 202
View the top 3 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/e2e::TestGenericPG
Stack Traces | 0s run time
=== RUN   TestGenericPG
=== PAUSE TestGenericPG
=== CONT  TestGenericPG
--- FAIL: TestGenericPG (0.00s)
github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuiteMySQL_CH
Stack Traces | 0.01s run time
=== RUN   TestPeerFlowE2ETestSuiteMySQL_CH
=== PAUSE TestPeerFlowE2ETestSuiteMySQL_CH
=== CONT  TestPeerFlowE2ETestSuiteMySQL_CH
--- FAIL: TestPeerFlowE2ETestSuiteMySQL_CH (0.01s)
github.com/PeerDB-io/peerdb/flow/e2e::TestGenericPG/Test_Simple_Schema_Changes
Stack Traces | 61.3s run time
=== RUN   TestGenericPG/Test_Simple_Schema_Changes
=== PAUSE TestGenericPG/Test_Simple_Schema_Changes
=== CONT  TestGenericPG/Test_Simple_Schema_Changes
    generic_test.go:237: UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT
    postgres.go:92: begin tearing down postgres schema pg_pq7hd5so
--- FAIL: TestGenericPG/Test_Simple_Schema_Changes (61.34s)
View the full list of 1 ❄️ flaky test(s)
github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuiteMySQL_CH/Test_MySQL_BinlogIncident

Flake rate in main: 37.50% (Passed 5 times, Failed 3 times)

Stack Traces | 52s run time
=== RUN   TestPeerFlowE2ETestSuiteMySQL_CH/Test_MySQL_BinlogIncident
=== PAUSE TestPeerFlowE2ETestSuiteMySQL_CH/Test_MySQL_BinlogIncident
=== CONT  TestPeerFlowE2ETestSuiteMySQL_CH/Test_MySQL_BinlogIncident
2026/06/24 05:46:50 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/06/24 05:46:50 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/06/24 05:46:50 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mych_nplit4md.test_float
    clickhouse_mysql_test.go:1544: 
        	Error Trace:	.../flow/e2e/clickhouse_mysql_test.go:1544
        	Error:      	Received unexpected error:
        	            	MySQL execute error: readInitialHandshake: io.ReadFull(header) failed. err EOF: connection was bad
        	Test:       	TestPeerFlowE2ETestSuiteMySQL_CH/Test_MySQL_BinlogIncident
2026/06/24 05:47:12 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mych_zraz94ae.test_extra_ch_cols
--- FAIL: TestPeerFlowE2ETestSuiteMySQL_CH/Test_MySQL_BinlogIncident (51.99s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The e2e test Test_MySQL_BinlogIncident failed with an EOF "connection was bad" error during the initial MySQL handshake to a freshly-started testcontainer — a container-startup race unrelated to the PR's DDL string-parsing change.
Confidence: 0.9

✅ Automatically retrying the workflow

View workflow run

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The PostgreSQL test TestGenericPG/Test_Simple_Schema_Changes hit a hardcoded 60s snapshot-status polling timeout (UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT) on only one of three parallel matrix variants under high CI concurrency, and is unrelated to the PR's MySQL changes.
Confidence: 0.9

✅ Automatically retrying the workflow

View workflow run

@ilidemi ilidemi merged commit aa72725 into main Jun 24, 2026
16 checks passed
@ilidemi ilidemi deleted the mysql/task-859 branch June 24, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants