Support null-terminated strings in MySQL DDL#4459
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
❌ 2 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
🔄 Flaky Test DetectedAnalysis: The e2e test Test_MySQL_BinlogIncident failed with an EOF "connection was bad" error during the initial MySQL handshake to a freshly-started testcontainer — a container-startup race unrelated to the PR's DDL string-parsing change. ✅ Automatically retrying the workflow |
🔄 Flaky Test DetectedAnalysis: The PostgreSQL test TestGenericPG/Test_Simple_Schema_Changes hit a hardcoded 60s snapshot-status polling timeout (UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT) on only one of three parallel matrix variants under high CI concurrency, and is unrelated to the PR's MySQL changes. ✅ Automatically retrying the workflow |
Trailing
\x00is the most common case of parse failures and also the most silly one.Closes DBI-859