feat(mysql): add counter metric for parseSQL errors#4498
Merged
Conversation
Track failures parsing MySQL QueryEvent SQL on the CDC path via a label-free counter to avoid high cardinality from varied SQL/error text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ilidemi
approved these changes
Jun 26, 2026
…r-out-the-rest-of-parse-failures
…out of metric counter
dtunikov
commented
Jun 26, 2026
ilidemi
reviewed
Jun 27, 2026
- classify ONLY index alter table as benign - classify maria rename tables as reported
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ilidemi
approved these changes
Jul 3, 2026
ilidemi
left a comment
ilidemi
left a comment
Contributor
There was a problem hiding this comment.
Awesome job. There are always more corner cases but if it ever becomes important, I wonder if the next step would be an actual tidb replacement (hopefully not).
Co-authored-by: Ilia Demianenko <ilia.demianenko@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a counter metric tracking failures parsing MySQL
QueryEventSQL on the CDC path.parse_sql_errorsInt64 counter inotel_metricsparseSQLerror branch inflow/connectors/mysql/cdc.goAlso partially resolves DBI-860.
The counter is intentionally label-free to avoid high cardinality from the varied SQL queries / error messages that can fail to parse.