Skip to content

Conversation

@Ulthran
Copy link
Contributor

@Ulthran Ulthran commented Aug 20, 2025

Summary

  • accept Undetermined fastqs without lane in filename
  • ensure archived fastqs are renamed with L001 when missing
  • test lane-less fastq parsing and backup

Testing

  • pytest

https://chatgpt.com/codex/tasks/task_e_689dfcb261788323b165309f4c2cb72e

Copilot AI review requested due to automatic review settings August 20, 2025 18:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for handling Illumina Undetermined FASTQ files that lack lane information in their filenames, ensuring they can be properly parsed and archived with appropriate lane identifiers.

  • Extends FASTQ filename parsing to handle lane-less Undetermined files
  • Updates archive logic to rename files with L001 when lane is missing from filename
  • Adds comprehensive test coverage for both parsing and backup functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
seqBackupLib/illumina.py Adds regex pattern for lane-less Undetermined FASTQ files and fallback to header lane info
seqBackupLib/backup.py Updates file path building and archiving to handle lane-less files with proper renaming
test/test_illumina.py Tests parsing of lane-less FASTQ files and archive directory building
test/test_backup.py Tests backup functionality for lane-less files including proper renaming
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Ulthran Ulthran merged commit af21ab9 into master Aug 20, 2025
6 checks passed
@Ulthran Ulthran deleted the codex/update-fastq-handling-for-new-formats branch August 20, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants