Remove carbon dependency - not needed#99
Conversation
WalkthroughThe pull request removes the 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 11-12: The changelog entry currently under the "### Added" header
is incorrect: split the line "Removed nesbot/carbon dependency; OAuth timestamps
use native `DateTimeImmutable` / `time()`." into two entries and place them
under the proper headers — move "Removed nesbot/carbon dependency" under a "###
Removed" section and place "OAuth timestamps use native `DateTimeImmutable` /
`time()`" under a "### Changed" section, ensuring the original "### Added"
header no longer contains this line and that spacing/markdown consistency
matches surrounding entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 6f32e3f8-bf80-4241-bf79-42000b0ceff5
📒 Files selected for processing (13)
CHANGELOG.mdcomposer.jsonsrc/Message.phpsrc/OAuth/ApiKeysMiddleware.phpsrc/OAuth/OAuthApi.phpsrc/OAuth/Tokens/PenneoTokensValidator.phpsrc/Validation.phpsrc/WebhookSubscription.phptests/unit/OAuth/OAuth/ApiKeysMiddlewareTest.phptests/unit/OAuth/OAuth/IsAuthorizedTest.phptests/unit/OAuth/OAuth/RefreshTokenMiddlewareTest.phptests/unit/OAuth/OAuthApiTest.phptests/unit/OAuth/PenneoTokensValidatorTest.php
💤 Files with no reviewable changes (6)
- tests/unit/OAuth/OAuth/IsAuthorizedTest.php
- src/Message.php
- src/OAuth/ApiKeysMiddleware.php
- src/WebhookSubscription.php
- composer.json
- src/Validation.php
| ### Added | ||
| - Removed nesbot/carbon dependency; OAuth timestamps use native `DateTimeImmutable` / `time()`. |
There was a problem hiding this comment.
Use the correct changelog category for this entry.
Line 11 uses ### Added, but Line 12 describes a dependency removal plus behavior change. Please move/split this into ### Removed and ### Changed for accurate release notes.
Suggested changelog adjustment
-### Added
-- Removed nesbot/carbon dependency; OAuth timestamps use native `DateTimeImmutable` / `time()`.
+### Changed
+- OAuth timestamps now use native `DateTimeImmutable` / `time()`.
+
+### Removed
+- Removed `nesbot/carbon` dependency.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### Added | |
| - Removed nesbot/carbon dependency; OAuth timestamps use native `DateTimeImmutable` / `time()`. | |
| ### Changed | |
| - OAuth timestamps now use native `DateTimeImmutable` / `time()`. | |
| ### Removed | |
| - Removed `nesbot/carbon` dependency. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` around lines 11 - 12, The changelog entry currently under the
"### Added" header is incorrect: split the line "Removed nesbot/carbon
dependency; OAuth timestamps use native `DateTimeImmutable` / `time()`." into
two entries and place them under the proper headers — move "Removed
nesbot/carbon dependency" under a "### Removed" section and place "OAuth
timestamps use native `DateTimeImmutable` / `time()`" under a "### Changed"
section, ensuring the original "### Added" header no longer contains this line
and that spacing/markdown consistency matches surrounding entries.
Carbon is not needed in this library