Conversation
Dfte
requested review from
Marshall-Hallenbeck,
NeffIsBack,
mpgn and
zblurx
as code owners
Member
|
Awesome! |
Collaborator
|
@Dfte can you update this PR to use our template? |
NeffIsBack
requested changes
Feb 6, 2026
nxc/modules/mssql_cbt.py
Outdated
| cbt_fake_value=b"" | ||
| ) | ||
|
|
||
| log_result(success) |
Member
There was a problem hiding this comment.
Probably a bit overkill to call a method. Just do if success: log(connection successfull...); else: log(connection unsuccessful...)
Contributor
Author
There was a problem hiding this comment.
Yeah you are right. Initially I had to use that in order not to duplicate code. Will remove now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the mssql_cbt module used to check whether Channel Binding is required or not.
IMPORTANT: this PR requires fortra/impacket#2098 being merged as I need to be able to inject a fake CBT value to test whether authentication works or not.
Note that CBT cannot be computed on local_auth or if TLS is not enforced (which explains the two first if else).