Refactor add-computer : use impacket CRUD#1098
Open
azoxlpf wants to merge 1 commit intoPennyw0rth:mainfrom
Open
Refactor add-computer : use impacket CRUD#1098azoxlpf wants to merge 1 commit intoPennyw0rth:mainfrom
azoxlpf wants to merge 1 commit intoPennyw0rth:mainfrom
Conversation
Contributor
Author
|
For the module to work, this PR needs to be merged first : #2112 |
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the add-computer module to support both
SAMRandLDAPSand to useimpacket’s LDAP CRUDoperations instead ofldap3.Previously, the module used a fallback to
LDAPSwhenSAMRfailed. It’s now clearer and more predictable to let the user choose the method via the protocol and options :nxc smbusesSAMR, andnxc ldap --port 636usesLDAPS. The module supports both protocols.Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Screenshots (if appropriate):
SMB :
LDAPS :
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)