Added --get-sid flag on mssql protocol#1099
Open
seriotonctf wants to merge 1 commit intoPennyw0rth:mainfrom
Open
Added --get-sid flag on mssql protocol#1099seriotonctf wants to merge 1 commit intoPennyw0rth:mainfrom
seriotonctf wants to merge 1 commit intoPennyw0rth:mainfrom
Conversation
mpgn
reviewed
Feb 7, 2026
| self.logger.debug(f"get_sid: DEFAULT_DOMAIN() result: {query_output}") | ||
| domain = query_output[0][""] | ||
|
|
||
| raw_sid = self.conn.sql_query(f"SELECT SUSER_SID('{domain}\\Domain Admins')")[0][""] |
Collaborator
There was a problem hiding this comment.
quick comment;
- it only work for english system
- what if it's local (no domain join)
Member
|
Hi and thanks for the PR. However the points by @mpgn are pretty valid concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added --get-sid flag on mssql protocol
Description
The
--get-sidflag has been added to the MSSQL protocol, providing a way to retrieve the domain SID via SQL queries (DEFAULT_DOMAIN()andSUSER_SID()), matching the existing--get-sidfunctionality already available in the LDAP protocol.This reuses the same SID resolution logic already present in
rid_brute(queryingSUSER_SID('DOMAIN\Domain Admins')and parsing with impacket'sSIDclass), but exposes it as a standalone enumeration option.Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Screenshots (if appropriate):
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)