[Module Enhancement] Entra ID module update#1100
Open
Mauriceter wants to merge 3 commits intoPennyw0rth:mainfrom
Open
[Module Enhancement] Entra ID module update#1100Mauriceter wants to merge 3 commits intoPennyw0rth:mainfrom
Mauriceter wants to merge 3 commits intoPennyw0rth:mainfrom
Conversation
Contributor
Author
|
I am wondering if I should add an optionnal check on services present on the AAD connect server to check if PHS or PTA is used. |
Member
|
Thanks for the PR, looks cool! |
Member
We would probably need SMB for that and while this is an LDAP module I don't think that would fit here. Maybe in another module. Also see #950 |
Contributor
Author
|
Yes exactly, I was thinking of checking it the same way it is done with enum_av. I won't add it as an option then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the entra-id module to detect other possible way to pivot from OnPrem domain to Entra ID.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
All installers for AAD connect and cloud sync can be found in the Entra Connect page of https://entra.microsoft.com
Screenshots (if appropriate):
This also fix the unhandled error when a the AAD connect fqdn can't be resolved.
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)