feat(smb): add --rid-users-export option to export RID enumerated users#1101
Open
H1DroZz wants to merge 1 commit intoPennyw0rth:mainfrom
Open
feat(smb): add --rid-users-export option to export RID enumerated users#1101H1DroZz wants to merge 1 commit intoPennyw0rth:mainfrom
H1DroZz wants to merge 1 commit intoPennyw0rth:mainfrom
Conversation
- Add --rid-users-export argument in proto_args.py - Implement rid_users_export() method in smb.py - Filter and export only SidTypeUser entries - Add E2E test
H1DroZz
requested review from
Marshall-Hallenbeck,
NeffIsBack,
mpgn and
zblurx
as code owners
Member
|
Hi and thanks for the PR. I don't think we should add even more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new --rid-users-export option to the SMB protocol, allowing users to export enumerated usernames from RID bruteforce directly to a file.
Type of change
Setup guide for the review
Python: 3.10+
OS: Linux
Target: Windows Domain Controller
Testing the new option:
Expected output:
File content (only SidTypeUser, sorted):
Screenshots (if appropriate):
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)