Refactor change-password#1226
Open
azoxlpf wants to merge 1 commit into
Open
Conversation
14 tasks
Member
|
Thanks for the PR! We should probably just merge #1191 first. |
Contributor
Author
Yeah, that would be simpler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
change-passwordto addLDAPandKerberossupport alongsideSMB (SAMR), so the module works when NTLM is off or RC4 is unavailable. LDAP is included because SAMR password changes do not refreshAES keymaterial in NTDS like an LDAPunicodePwdupdate, and SAMR changes can be blocked by policy on newer Windows (e.g. Server 2025), where LDAP remains viable when permitted.Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
run
nxc smb/ldap -M change-passwordScreenshots (if appropriate):
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)