Skip to content

Fix: Guid PKs bulk-inserted as NULL without explicit ValueGeneratedNever() #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhenX merged 4 commits into from
May 29, 2026
Merged

Fix: Guid PKs bulk-inserted as NULL without explicit ValueGeneratedNever() #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64acfeb
Initial plan
Copilot May 26, 2026
489ae1e
Fix: include Guid PKs in bulk INSERT by default (unless they have a S…
Copilot May 26, 2026
3768333
Fix: also treat HasDefaultValue() Guid columns as generated; assert G…
Copilot May 29, 2026
4a5c9e8
Fix: use FindAnnotation(RelationalAnnotationNames.DefaultValue) inste…
Copilot May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/PhenX.EntityFrameworkCore.BulkInsert/Metadata/ColumnMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ public ColumnMetadata(IProperty property, SqlDialectBuilder dialect, IComplexPr
QuotedColumName = dialect.Quote(ColumnName);
StoreDefinition = GetStoreDefinition(property);
ClrType = property.ClrType;
IsGenerated = property.ValueGenerated != ValueGenerated.Never;
IsGenerated = property.ValueGenerated != ValueGenerated.Never
&& (property.GetDefaultValueSql() != null
|| property.GetComputedColumnSql() != null
|| property.FindAnnotation(RelationalAnnotationNames.DefaultValue) != null
|| (property.ClrType != typeof(Guid) && property.ClrType != typeof(Guid?)));
Comment on lines +25 to +28
}

private readonly Func<object, object?> _getter;
Expand Down
6 changes: 0 additions & 6 deletions tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestDbContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
.HasConversion(new DateTimeToBinaryConverter());
});

modelBuilder.Entity<TestEntityWithGuidId>(builder =>
{
builder.Property(e => e.Id)
.ValueGeneratedNever();
});

modelBuilder.Entity<TestEntityWithComplexType>(builder =>
{
builder
Expand Down
11 changes: 4 additions & 7 deletions tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,15 +314,12 @@ public async Task InsertEntities_WithGeneratedGuidId(InsertStrategy strategy)
new TestEntityWithGuidId { TestRun = _run, Id = Guid.NewGuid(), Name = $"{_run}_Entity2" }
};

// Act
var insertedEntities = await _context.InsertWithStrategyAsync(strategy, entities, configure => configure.CopyGeneratedColumns = true);
// Act - Guid PKs should be included in INSERT without requiring CopyGeneratedColumns = true
var insertedEntities = await _context.InsertWithStrategyAsync(strategy, entities);

// Assert
// Assert - all fields including the application-assigned Guid Id should be preserved
insertedEntities.Should().BeEquivalentTo(entities,
o=> o
.RespectingRuntimeTypes()
.Excluding(e => e.Id)
);
o => o.RespectingRuntimeTypes());
Comment on lines 321 to +322
}

[SkippableTheory]
Expand Down
4 changes: 2 additions & 2 deletions tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Merge/MergeTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ public async Task InsertEntities_MultipleTimes_WithGuidId(InsertStrategy strateg
Update = (inserted, excluded) => inserted,
});

// Assert
// Assert - all fields including the application-assigned Guid Id should be preserved
insertedEntities.Should().BeEquivalentTo(entities,
o => o.RespectingRuntimeTypes().Excluding(e => e.Id));
o => o.RespectingRuntimeTypes());
}

[SkippableTheory]
Expand Down
Loading