Skip to content

Conversation

@thibaultzanini
Copy link
Collaborator

Fixed critical property name mismatches and inconsistencies in mjson files:

data/model root level fixes:

  • digital-asset.mjson: Fixed secureLocation property name (was signedLocation)
  • physical-dimension.mjson: Fixed name property (was value)
  • identity.mjson: Fixed provider property name (was scope) and standardized prototype paths
  • unit.mjson: Fixed name property (was value)
  • ordering-rule.mjson: Fixed propertyvalidationRules typo (now validationRules)
  • variable.mjson: Fixed description typo (secialized → serialized)

data/model/geo fixes:

  • Standardized all geo files to use "values" instead of "properties"
  • Affected files: line-string, multi-line-string, multi-point, polygon, point, circle, geometry, multi-polygon, projection, position

These fixes ensure property descriptors match their references and maintain consistency across the codebase.

Fixed critical property name mismatches and inconsistencies in mjson files:

data/model root level fixes:
- digital-asset.mjson: Fixed secureLocation property name (was signedLocation)
- physical-dimension.mjson: Fixed name property (was value)
- identity.mjson: Fixed provider property name (was scope) and standardized prototype paths
- unit.mjson: Fixed name property (was value)
- ordering-rule.mjson: Fixed propertyvalidationRules typo (now validationRules)
- variable.mjson: Fixed description typo (secialized → serialized)

data/model/geo fixes:
- Standardized all geo files to use "values" instead of "properties"
- Affected files: line-string, multi-line-string, multi-point, polygon, point, circle, geometry, multi-polygon, projection, position

These fixes ensure property descriptors match their references and maintain consistency across the codebase.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes critical property name mismatches, typos, and inconsistencies in MJSON metadata files. The changes ensure property descriptors correctly match their actual property names and standardize the structure across geo-related files.

Key changes:

  • Fixed property name mismatches where descriptor keys didn't align with their "name" values (e.g., secureLocation/signedLocation, provider/scope, name/value)
  • Standardized all geo files to use "values" instead of "properties" for property descriptors
  • Corrected spelling typo in variable.mjson description (secialized → serialized)

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
data/model/variable.mjson Fixed spelling typo in description (secialized → serialized)
data/model/unit.mjson Fixed property name from "value" to "name" to match actual property
data/model/physical-dimension.mjson Fixed property name from "value" to "name" to match actual property
data/model/ordering-rule.mjson Fixed typo: propertyvalidationRules → validationRules
data/model/identity.mjson Fixed provider property name (was scope) and standardized prototype path
data/model/digital-asset.mjson Fixed secureLocation property name (was signedLocation)
data/model/geo/projection.mjson Standardized to use "values" instead of "properties"
data/model/geo/position.mjson Standardized to use "values" instead of "properties"
data/model/geo/polygon.mjson Standardized to use "values" instead of "properties"
data/model/geo/point.mjson Standardized to use "values" instead of "properties"
data/model/geo/multi-polygon.mjson Standardized to use "values" instead of "properties"
data/model/geo/multi-point.mjson Standardized to use "values" instead of "properties"
data/model/geo/multi-line-string.mjson Standardized to use "values" instead of "properties"
data/model/geo/line-string.mjson Standardized to use "values" instead of "properties"
data/model/geo/geometry.mjson Standardized to use "values" instead of "properties"
data/model/geo/circle.mjson Standardized to use "values" instead of "properties"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thibaultzanini thibaultzanini self-assigned this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants