Check MJSON files for typos and errors #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thibaultzanini
commented
Jan 8, 2026
thibaultzanini
commented
- software.mjson: fix property name mismatch (owner -> maker)
- user-agent-window.mjson: add missing sizeTimeLog and screenTimeLog to propertyDescriptors
- user-identity.mjson: fix property naming inconsistency (serializable -> isSerializable)
- web-socket-session-connection.mjson: add missing existenceTimeRange to propertyDescriptors
- software.mjson: fix property name mismatch (owner -> maker) - user-agent-window.mjson: add missing sizeTimeLog and screenTimeLog to propertyDescriptors - user-identity.mjson: fix property naming inconsistency (serializable -> isSerializable) - web-socket-session-connection.mjson: add missing existenceTimeRange to propertyDescriptors
thibaultzanini
commented
Jan 8, 2026
| {"@": "name"}, | ||
| {"@": "version"}, | ||
| {"@": "owner"}, | ||
| {"@": "maker"}, |
Collaborator
Author
There was a problem hiding this comment.
@marchant there is no owner property declared here.
There was a problem hiding this comment.
Pull request overview
This pull request fixes typos and errors in MJSON model descriptor files by correcting property name mismatches and adding missing property descriptor references.
- Fixed property name inconsistencies (
serializable→isSerializable,owner→maker) - Added missing property descriptor references that were defined but not listed in propertyDescriptors arrays
- Ensured consistency between property descriptor definitions and their references
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web-socket-session-connection.mjson | Added missing existenceTimeRange to propertyDescriptors array |
| user-identity.mjson | Fixed property naming inconsistency from serializable to isSerializable |
| user-agent-window.mjson | Added missing sizeTimeLog and screenTimeLog to propertyDescriptors array |
| software.mjson | Corrected property reference from owner to maker |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.