Check messaging channel files for typos #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thibaultzanini
commented
Jan 8, 2026
thibaultzanini
commented
- Fix country property to reference CountryDescriptor instead of PartySMSNumberDescriptor in phone-number.mjson
- Fix supportsRichCommunication property name field in phone-number.mjson
- Fix personParty property to reference PersonDescriptor instead of OrganizationDescriptor in party-messaging-channel.mjson
- Fix country property to reference CountryDescriptor instead of PartySMSNumberDescriptor in phone-number.mjson - Fix supportsRichCommunication property name field in phone-number.mjson - Fix personParty property to reference PersonDescriptor instead of OrganizationDescriptor in party-messaging-channel.mjson
thibaultzanini
commented
Jan 8, 2026
| "valueType": "object", | ||
| "cardinality": 1, | ||
| "valueDescriptor": {"@": "OrganizationDescriptor"} | ||
| "valueDescriptor": {"@": "PersonDescriptor"} |
| "valueType": "object", | ||
| "cardinality": 1, | ||
| "valueDescriptor": {"@": "PartySMSNumberDescriptor"} | ||
| "valueDescriptor": {"@": "CountryDescriptor"} |
| "prototype": "core/meta/property-descriptor", | ||
| "values": { | ||
| "name": "supportsiMessage", | ||
| "name": "supportsRichCommunication", |
There was a problem hiding this comment.
Pull request overview
This pull request fixes three typos in messaging channel model descriptor files where property descriptors were referencing incorrect types or had mismatched property names.
- Corrected
countryproperty to referenceCountryDescriptorinstead ofPartySMSNumberDescriptor - Fixed
supportsRichCommunicationproperty name field to match its descriptor key - Corrected
personPartyproperty to referencePersonDescriptorinstead ofOrganizationDescriptor
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| data/model/messaging-channel/phone-number.mjson | Fixed two typos: country property now correctly references CountryDescriptor, and supportsRichCommunication property name now matches its descriptor key |
| data/model/messaging-channel/party-messaging-channel.mjson | Fixed personParty property to correctly reference PersonDescriptor instead of OrganizationDescriptor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.