Skip to content

Improve CI and fix tests#156

Merged
christophfroehlich merged 7 commits into
mainfrom
improve/ci
Mar 11, 2026
Merged

Improve CI and fix tests#156
christophfroehlich merged 7 commits into
mainfrom
improve/ci

Conversation

@christophfroehlich

@christophfroehlich christophfroehlich commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

Build also the tests on the non-cmake CI jobs.

Needs some changes to successfully build on windows, and the test on RHEL8 with a different fmt version:

    /__w/RSL/RSL/src/PickNikRobotics/RSL/tests/parameter_validators.cpp:347: FAILED:
      CHECK( result.error() == "Parameter 'test' with the value '0' is not in the set '{1, 2, 3.5}'" )
    with expansion:
      "Parameter 'test' with the value '0.0' is not in the set '{1.0, 2.0, 3.5}'"
      ==
      "Parameter 'test' with the value '0' is not in the set '{1, 2, 3.5}'"

@christophfroehlich christophfroehlich changed the title Improve CI Improve CI and fix tests Mar 1, 2026

@otamachan otamachan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the same changes on my fork (otamachan#1) and all CI passed, including Windows and RHEL.

The stringify helper with {:g} is a reasonable approach for the fmt output inconsistency across platforms.

@christophfroehlich christophfroehlich merged commit 248bfdb into main Mar 11, 2026
48 checks passed
@christophfroehlich christophfroehlich deleted the improve/ci branch March 11, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants