Add thread-safe methods to add and remove data sinks in LogChannel#65
Conversation
henrygerardmoore
left a comment
There was a problem hiding this comment.
This looks good to me, thank you very much for your PR! I have one minor comment and a request: could you add a simple test that demonstrates the use case you mention in this PR? It can just ensure that the functionality of adding and removing sinks while logging functions correctly, but I think it's important to ensure future changes won't impact this functionality.
|
@facontidavide I think you should take a look at this PR too, in case I'm missing anything |
|
Sounds good, on it:) |
Great, thanks! Please re-request me when you're ready for a second review 😄 |
|
Hello @Basiljamal1, are you still working on this? Just checking in, no pressure :) |
Donzo, added simple tests |
henrygerardmoore
left a comment
There was a problem hiding this comment.
Made a few small tweaks and will merge if the workflow succeeds. Thanks for making this and for your patience!
Summary
This PR aims to provide the ability to add and remove sinks from data channels at runtime. It introduces thread-safe methods for remove and add data sinks in the
LogChannelclass.Impact
Please review the changes and provide feedback. 🙏