Add eigen support#67
Open
PepMS wants to merge 4 commits into
Open
Conversation
| RegistrationID registerValue(const std::string& name, const std::array<T, N>* value); | ||
|
|
||
| #if DATA_TAMER_EIGEN_SUPPORT | ||
| RegistrationID registerValue(const std::string& prefix, const Eigen::VectorXd* value); |
There was a problem hiding this comment.
Hi @PepMS, how are you doing?
Thank you very much for this PR, it's really helpful.
I have my 2 cents comment on this work.
I would believe that using the ground rules for Eigen for passing Eigen object into functions would be beneficial here.
Either using templates or Eigen::Ref.
See: https://libeigen.gitlab.io/eigen/docs-5.0/TopicFunctionTakingEigenTypes.html
My comment applies for the full PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #66 , this PR adds the possibility to log Eigen::VectorXd objects.
Adding Eigen compatibility is configurable through cmake variables and the use of preprocessor directives inside the code.