Added missing gmock/gtest dependency #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
christophfroehlich
requested changes
Jan 14, 2026
Collaborator
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
wait, shouldn't this be in the example package? There is no test in generate_parameter_library package
christophfroehlich
changed the title
christophfroehlich
approved these changes
Jan 27, 2026
Collaborator
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
I added gmock and gtest dependency to the example, where the actual find_package() is called
christophfroehlich
merged commit f825d7c
into
PickNikRobotics:main
8 of 9 checks passed
Talha-deepx
added a commit
to DeepX-inc/generate_parameter_library
that referenced
this pull request
Jan 28, 2026
* Use a temporary build directory for Python module output (PickNikRobotics#303) * Added missing gmock/gtest dependency (PickNikRobotics#304) --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> * make scripts accessible to find_program cmake function. --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Błażej Sowa <bsowa123@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Alexandre Arnoux <alexandre.arnoux@deepx.co.jp> Co-authored-by: alexandre-arnoux-dx <148032753+AArnouxDeepX@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://build.ros2.org/view/Rdev/job/Rdev__generate_parameter_library__ubuntu_noble_amd64/42/console#console-section-1