Skip to content

Update main With Changes from example_ws#54

Merged
JWhitleyWork merged 1 commit into
mainfrom
update-main
May 15, 2026
Merged

Update main With Changes from example_ws#54
JWhitleyWork merged 1 commit into
mainfrom
update-main

Conversation

@JWhitleyWork
Copy link
Copy Markdown
Member

No description provided.

@JWhitleyWork JWhitleyWork self-assigned this May 15, 2026
Copilot AI review requested due to automatic review settings May 15, 2026 18:17
@JWhitleyWork JWhitleyWork requested review from nbbrooks and shaur-k May 15, 2026 18:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository tooling/configuration to align main with the example_ws workspace, primarily by refreshing developer workflow hooks and expanding Git LFS tracking for additional asset types.

Changes:

  • Bump versions of multiple pre-commit hooks and add two new local pre-commit checks.
  • Expand Git LFS patterns in .gitattributes to include common image formats (and an additional 3D-extension entry).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.pre-commit-config.yaml Updates hook revisions (pre-commit/Black/codespell/yamllint/markdown-link-check/hadolint/Prettier) and adds two local hooks for XML/config validation.
.gitattributes Adds Git LFS tracking for more file extensions (images and an extra 3D extension entry).
Comments suppressed due to low confidence (2)

.pre-commit-config.yaml:89

  • The Prettier hook bumps mirrors-prettier to v4.0.0-alpha.8, but additional_dependencies still pins prettier@3.1.0. This mixes major versions and can lead to inconsistent or failing installs. Either keep the mirror at v3.1.0 (matching the dependency) or update/remove the prettier@... pin so the configured versions are consistent.
  - repo: https://github.com/pre-commit/mirrors-prettier
    rev: "v4.0.0-alpha.8"
    hooks:
      # Use Prettier to lint XML files because, well.. its rules are prettier than most linters, as the name implies.
      # Also we use it in the UI, so it's familiar.
      - id: prettier
        additional_dependencies:
          - "prettier@3.1.0"
          - "@prettier/plugin-xml@3.3.1"

.pre-commit-config.yaml:103

  • These new local pre-commit hooks reference ./scripts/check_objective_favorites.sh and ./scripts/check_mujoco_viewer.sh, but there is no scripts/ directory in the repository, so running pre-commit will fail with a missing entrypoint. Add the referenced scripts (and ensure they are executable) or adjust entry to the correct path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .pre-commit-config.yaml Outdated
Comment thread .gitattributes
@JWhitleyWork JWhitleyWork enabled auto-merge (squash) May 15, 2026 18:24
@JWhitleyWork JWhitleyWork merged commit 9fa9e0f into main May 15, 2026
1 check passed
@JWhitleyWork JWhitleyWork deleted the update-main branch May 15, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants