Update main With Changes from example_ws#54
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates repository tooling/configuration to align main with the example_ws workspace, primarily by refreshing developer workflow hooks and expanding Git LFS tracking for additional asset types.
Changes:
- Bump versions of multiple pre-commit hooks and add two new local pre-commit checks.
- Expand Git LFS patterns in
.gitattributesto include common image formats (and an additional 3D-extension entry).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .pre-commit-config.yaml | Updates hook revisions (pre-commit/Black/codespell/yamllint/markdown-link-check/hadolint/Prettier) and adds two local hooks for XML/config validation. |
| .gitattributes | Adds Git LFS tracking for more file extensions (images and an extra 3D extension entry). |
Comments suppressed due to low confidence (2)
.pre-commit-config.yaml:89
- The Prettier hook bumps
mirrors-prettiertov4.0.0-alpha.8, butadditional_dependenciesstill pinsprettier@3.1.0. This mixes major versions and can lead to inconsistent or failing installs. Either keep the mirror at v3.1.0 (matching the dependency) or update/remove theprettier@...pin so the configured versions are consistent.
- repo: https://github.com/pre-commit/mirrors-prettier
rev: "v4.0.0-alpha.8"
hooks:
# Use Prettier to lint XML files because, well.. its rules are prettier than most linters, as the name implies.
# Also we use it in the UI, so it's familiar.
- id: prettier
additional_dependencies:
- "prettier@3.1.0"
- "@prettier/plugin-xml@3.3.1"
.pre-commit-config.yaml:103
- These new local pre-commit hooks reference
./scripts/check_objective_favorites.shand./scripts/check_mujoco_viewer.sh, but there is noscripts/directory in the repository, so running pre-commit will fail with a missing entrypoint. Add the referenced scripts (and ensure they are executable) or adjustentryto the correct path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shaur-k
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.