Fix deprecation warning from hardware interface.#35
Closed
marcoag wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
Contributor
|
Without this PR, we cannot release ros2_control to Jazzy. |
Author
|
For your consideration: as @bmagyar suggested in this rosdistro PR removing the |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to JafarAbdi/feetech_ros2_driver#14.
I'm currently working on a jazzy patch sync and this package is under a regression error due to a deprecation in the
ros2_controlhardware interface and since this package has enabled warnings as errors. To avoid the wipe out of the package injazzywith the coming sync I suggest we merge this fix and release a new version containing the changes tojazzy.This PR is a fix to avoid the warning by updating to the
on_initsignature fromconst hardware_interface::HardwareInfo& infotoconst hardware_interface::HardwareComponentInterfaceParams& params. Additionally it also updates all references to access hardware info via params.hardware_info (e.g., params.hardware_info.hardware_parameters, params.hardware_info.joints)Alternatively you can remove the warnings as errors option but I guess updating is a good move forward.
After we apply the fix we need a release to
jazzyon the rosdistro.